Skip to content

Commit ee3e61b

Browse files
Version 4.0.1 (#1)
## Bugfix - Module expected to always have a parameter for instance 1. If this was not the case it did not return amount of instances within function 'getModuleParameterName' but it is necessary for other modules to load setup correctly event without saving parameters for instance 1. - Minor UI updates --------- Co-authored-by: kogliinSICKAG <131916494+kogliinSICKAG@users.noreply.github.com>
1 parent 4e09824 commit ee3e61b

File tree

8 files changed

+35
-20
lines changed

8 files changed

+35
-20
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
# Changelog
22
All notable changes to this project will be documented in this file.
33

4+
## Release 4.0.1
5+
6+
### Bugfix
7+
- Module expected to always have a parameter for instance 1. If this was not the case it did not return amount of instances within function 'getModuleParameterName' but it is necessary for other modules to load setup correctly event without saving parameters for instance 1.
8+
49
## Release 4.0.0
510

611
### Improvements

CSK_Module_PersistentData/pages/pages/CSK_Module_PersistentData/CSK_Module_PersistentData.html

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,13 @@
3636
</crown-edpws-binding>
3737
</davinci-text-area>
3838
<davinci-button id="B_LoadData" type="primary" icon-position="append">
39-
<span>Load Data</span>
39+
<span>Load Persistent Data</span>
4040
<crown-binding event="submit" name="CSK_PersistentData/loadContent"
4141
auto-commit>
4242
</crown-binding>
4343
</davinci-button>
4444
<davinci-button id="B_SaveData" type="primary" icon-position="append">
45-
<span>Save Persistend Data</span>
45+
<span>Save Persistent Data</span>
4646
<crown-binding event="submit" name="CSK_PersistentData/saveData"
4747
auto-commit>
4848
</crown-binding>
@@ -134,5 +134,4 @@
134134
</crown-edpws-binding>
135135
</stacked-view>
136136
</layout-column>
137-
138137
</layout-row>
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
document.addEventListener('sopasjs-ready', () => {
2+
setTimeout(() => {
3+
document.title = 'CSK_Module_PersistentData'
4+
}, 500);
5+
})

CSK_Module_PersistentData/project.mf.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@
163163
</serves>
164164
</crown>
165165
<meta key="author">SICK AG</meta>
166-
<meta key="version">4.0.0</meta>
166+
<meta key="version">4.0.1</meta>
167167
<meta key="priority">low</meta>
168168
<meta key="copy-protected">false</meta>
169169
<meta key="read-protected">false</meta>

CSK_Module_PersistentData/scripts/Configuration/PersistentData/PersistentData_Controller.lua

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,11 @@ local function getModuleParameterName(module, instance)
194194
return persistentData_Model.parameters.parameterNames[pos], persistentData_Model.parameters.loadOnReboot[pos], persistentData_Model.parameters.totalInstances[module]
195195
end
196196
else
197-
return nil
197+
if persistentData_Model.parameters.totalInstances[module] then
198+
return nil, nil, persistentData_Model.parameters.totalInstances[module]
199+
else
200+
return nil
201+
end
198202
end
199203
else
200204
if persistentData_Model.parameters.parameterNames[module] then

README.md

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,19 +7,21 @@ Module to provide data storage functionality. Can be used from other modules to
77
## How to Run
88

99
The app provides data storage functionality, incl. complex data types like Images, EdgeMatcher etc.
10-
There is also a UI available.
11-
For further information regarding the internal used functions / events check out the [documentation](https://raw.githack.com/SICKAppSpaceCodingStarterKit/CSK_Module_PersistentData/main/docu/CSK_Module_PersistentData.html) in the folder "docu".
10+
There is also a GUI available.
11+
For further information regarding the internally used functions / events, check out the [documentation](https://raw.githack.com/SICKAppSpaceCodingStarterKit/CSK_Module_PersistentData/main/docu/CSK_Module_PersistentData.html) in the folder "docu".
1212

1313
## Information
1414

1515
Tested on
16-
17-
1. SIM1012 - Firmware 2.2.0
18-
2. SICK AppEngine - Firmware 1.3.2
16+
|Device|Firmware|Module version|
17+
|--|--|--|
18+
|SICK AppEngine|v1.5.0|v4.0.1|
19+
|InspectorP631|v4.2.1|v4.0.1|
20+
|SIM1012|v2.2.0|v4.0.0|
1921

2022
This module is part of the SICK AppSpace Coding Starter Kit developing approach.
21-
It is programmed in an object oriented way. Some of these modules use kind of "classes" in Lua to make it possible to reuse code / classes in other projects.
22-
In general it is not neccessary to code this way, but the architecture of this app can serve as a sample to be used especially for bigger projects and to make it easier to share code.
23+
It is programmed in an object-oriented way. Some of these modules use kind of "classes" in Lua to make it possible to reuse code / classes in other projects.
24+
In general, it is not neccessary to code this way, but the architecture of this app can serve as a sample to be used especially for bigger projects and to make it easier to share code.
2325
Please check the [documentation](https://github.com/SICKAppSpaceCodingStarterKit/.github/blob/main/docu/SICKAppSpaceCodingStarterKit_Documentation.md) of CSK for further information.
2426

2527
## Topics

docu/CSK_Module_PersistentData.html

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<meta name="viewport" content="width=device-width, initial-scale=1.0">
77
<meta name="generator" content="Asciidoctor 2.0.12">
88
<meta name="author" content="SICK AG">
9-
<title>Documentation - CSK_Module_PersistentData 4.0.0</title>
9+
<title>Documentation - CSK_Module_PersistentData 4.0.1</title>
1010
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.7.0/css/font-awesome.min.css">
1111
<style>
1212
/* Stylesheet for CodeRay to match GitHub theme | MIT License | http://foundation.zurb.com */
@@ -615,11 +615,11 @@
615615
</head>
616616
<body class="article toc2 toc-left">
617617
<div id="header">
618-
<h1>Documentation - CSK_Module_PersistentData 4.0.0</h1>
618+
<h1>Documentation - CSK_Module_PersistentData 4.0.1</h1>
619619
<div class="details">
620620
<span id="author" class="author">SICK AG</span><br>
621-
<span id="revnumber">version 4.0.0,</span>
622-
<span id="revdate">2023-06-15</span>
621+
<span id="revnumber">version 4.0.1,</span>
622+
<span id="revdate">2024-04-16</span>
623623
</div>
624624
<div id="toc" class="toc2">
625625
<div id="toctitle">Table of Contents</div>
@@ -697,11 +697,11 @@ <h2 id="_document_metadata">Document metadata</h2>
697697
</tr>
698698
<tr>
699699
<th class="tableblock halign-left valign-top"><p class="tableblock">Version</p></th>
700-
<td class="tableblock halign-left valign-top"><p class="tableblock">4.0.0</p></td>
700+
<td class="tableblock halign-left valign-top"><p class="tableblock">4.0.1</p></td>
701701
</tr>
702702
<tr>
703703
<th class="tableblock halign-left valign-top"><p class="tableblock">Date</p></th>
704-
<td class="tableblock halign-left valign-top"><p class="tableblock">2023-06-15</p></td>
704+
<td class="tableblock halign-left valign-top"><p class="tableblock">2024-04-16</p></td>
705705
</tr>
706706
<tr>
707707
<th class="tableblock halign-left valign-top"><p class="tableblock">Author</p></th>
@@ -2229,8 +2229,8 @@ <h6 id="_sample_auto_generated_30">Sample (auto-generated)</h6>
22292229
</div>
22302230
<div id="footer">
22312231
<div id="footer-text">
2232-
Version 4.0.0<br>
2233-
Last updated 2023-06-15 11:16:34 +0200
2232+
Version 4.0.1<br>
2233+
Last updated 2024-04-16 16:31:09 +0200
22342234
</div>
22352235
</div>
22362236
<script type="text/javascript">

docu/media/UI_Screenshot.png

30.4 KB
Loading

0 commit comments

Comments
 (0)