-
Notifications
You must be signed in to change notification settings - Fork 101
Props/umbrellas #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: oss
Are you sure you want to change the base?
Props/umbrellas #363
Conversation
Add tint palette for more colors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @MrKoddy and thank you for your PR.
Please follow all of my review and fix them before next steps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why your files are placed here, and you have a duplicate file in resources/[props]/soz-prop-umbrella-colors/p_amb_brolly_01/p_amb_brolly_01.ydr.xml
also ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not modify Vanilla files, if you try to add or modify contents or properties of a vanilla files, please add a custom name on the prefix and create a fully new ytyp files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicated files ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DDS files are not loaded by FiveM, please add them in a YTD files.
Following all of your DDS files inside this folder.
I don't see any code, how would it be possible to choose the color? |
I'll make changes you mention here. I didn't know I should write some code and I can't code. I made this tint palette following a tutorial which didn't talk about coding so player can chose the color in fivem. I still can transform the PR into indivdual files so we have many colors for umbrellas |
Sorry for the delay, I was on another project. I edited the props and followed the instructions, everything should be ok. I didn't do with tint palette because I can't program. So there 8 umbrellas variants
I pushed a commit. I think everything is good. Making the texture dictionary didn't work for this project |
Updated a color and ytyp
#362