Skip to content

Conversation

MrKoddy
Copy link

@MrKoddy MrKoddy commented Apr 5, 2025

MrKoddy added 2 commits April 5, 2025 22:00
Add tint palette for more colors
Copy link
Contributor

@Rigonkmalk Rigonkmalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @MrKoddy and thank you for your PR.

Please follow all of my review and fix them before next steps.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why your files are placed here, and you have a duplicate file in resources/[props]/soz-prop-umbrella-colors/p_amb_brolly_01/p_amb_brolly_01.ydr.xml also ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not modify Vanilla files, if you try to add or modify contents or properties of a vanilla files, please add a custom name on the prefix and create a fully new ytyp files.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated files ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DDS files are not loaded by FiveM, please add them in a YTD files.

Following all of your DDS files inside this folder.

@Laikker
Copy link
Contributor

Laikker commented Apr 11, 2025

I don't see any code, how would it be possible to choose the color?

@MrKoddy
Copy link
Author

MrKoddy commented Apr 12, 2025

I'll make changes you mention here. I didn't know I should write some code and I can't code. I made this tint palette following a tutorial which didn't talk about coding so player can chose the color in fivem. I still can transform the PR into indivdual files so we have many colors for umbrellas

Sorry for the delay, I was on another project. I edited the props and followed the instructions, everything should be ok. I didn't do with tint palette because I can't program. So there 8 umbrellas variants
@MrKoddy
Copy link
Author

MrKoddy commented Jul 7, 2025

I pushed a commit. I think everything is good. Making the texture dictionary didn't work for this project

Updated a color and ytyp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants