Skip to content

Conversation

MGaetan89
Copy link
Contributor

@MGaetan89 MGaetan89 commented Feb 27, 2025

Description

This PR moves the Java version used in workflows into its own file and makes Renovate update that version to the latest LTS.

Changes made

  • Extract the Java version used in workflow files into its own .github/workflows/.java-version file.
  • Update Renovate's configuration so it can update the Java version to the latest LTS version.

Source

This was inspired by the work done in cashapp/turbine:

@MGaetan89 MGaetan89 self-assigned this Feb 27, 2025
@github-project-automation github-project-automation bot moved this to ✏️ Draft in Pillarbox Feb 27, 2025
Copy link

github-actions bot commented Feb 27, 2025

Code Coverage

Overall Project 29.82% 🟢

There is no coverage information present for the Files changed

@MGaetan89 MGaetan89 moved this from ✏️ Draft to 🚧 In Progress in Pillarbox Feb 27, 2025
@MGaetan89 MGaetan89 requested a review from StaehliJ February 27, 2025 12:51
@MGaetan89 MGaetan89 moved this from 🚧 In Progress to 🍿 Code Review in Pillarbox Feb 27, 2025
@MGaetan89 MGaetan89 marked this pull request as draft February 27, 2025 13:07
@MGaetan89 MGaetan89 moved this from 🍿 Code Review to 🚧 In Progress in Pillarbox Feb 27, 2025
@MGaetan89
Copy link
Contributor Author

I'm converting this to a draft because it will need to be updated once #42 has been merged.

@MGaetan89 MGaetan89 force-pushed the extract_java_version branch from 7b591c3 to bd36615 Compare February 28, 2025 09:15
@MGaetan89 MGaetan89 changed the base branch from main to 37-integrate-dokka February 28, 2025 09:15
@MGaetan89 MGaetan89 force-pushed the extract_java_version branch from bd36615 to 2357c41 Compare February 28, 2025 09:20
@MGaetan89 MGaetan89 marked this pull request as ready for review February 28, 2025 09:20
@MGaetan89
Copy link
Contributor Author

I've updated this PR to depend on #42, so I could already make the necessary changes.

@MGaetan89 MGaetan89 moved this from 🚧 In Progress to 🍿 Code Review in Pillarbox Feb 28, 2025
@MGaetan89 MGaetan89 force-pushed the extract_java_version branch from 2357c41 to 27af874 Compare February 28, 2025 15:52
@MGaetan89 MGaetan89 force-pushed the 37-integrate-dokka branch from e98ac7e to 61e21a8 Compare March 5, 2025 07:07
@MGaetan89 MGaetan89 force-pushed the extract_java_version branch from 27af874 to e4c341f Compare March 5, 2025 07:08
@MGaetan89 MGaetan89 force-pushed the 37-integrate-dokka branch from 61e21a8 to 3428bb1 Compare March 5, 2025 14:27
@MGaetan89 MGaetan89 force-pushed the extract_java_version branch from e4c341f to fc9991c Compare March 5, 2025 14:35
@MGaetan89 MGaetan89 force-pushed the 37-integrate-dokka branch from 7bfbcef to 07992ea Compare March 6, 2025 13:33
@MGaetan89 MGaetan89 force-pushed the extract_java_version branch from fc9991c to 048f65e Compare March 6, 2025 13:35
Base automatically changed from 37-integrate-dokka to main March 7, 2025 09:37
@MGaetan89 MGaetan89 force-pushed the extract_java_version branch from 048f65e to 9c8adcf Compare March 7, 2025 09:44
@MGaetan89 MGaetan89 added this pull request to the merge queue Mar 7, 2025
Merged via the queue into main with commit ee62ecf Mar 7, 2025
10 checks passed
@MGaetan89 MGaetan89 deleted the extract_java_version branch March 7, 2025 09:47
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants