Skip to content

Conversation

jboix
Copy link
Member

@jboix jboix commented Apr 30, 2024

Description

Replaces Rollup and Parcel with Vite as the sole build tool in order to reduce complexity. The changes involve:

Changes made

  • Removed .parcelrc and rollup.config.js, as their functionalities are now handled by Vite.
  • Introduced multiple Vite config to support the various build outputs previously managed by Rollup.
  • Updated package.json to integrate Vite dependencies and remove those related to Rollup and Parcel (2 Rollup plugins have been retained, including Babel to enhance browser compatibility and Terser for minifying the UMD build).
  • Modified scss/pillarbox.scss to enhance compatibility with the new Vite build setup. This update includes simplifying SCSS imports, making it easier to resolve external dependencies without depending on the file's location.
  • The server previously started by Parcel for the demo pages is now efficiently handled by Vite's native development server.

@jboix jboix requested a review from amtins April 30, 2024 14:54
@jboix jboix self-assigned this Apr 30, 2024
Copy link

github-actions bot commented Apr 30, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-23 14:16 UTC

Copy link

github-actions bot commented Apr 30, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 98.1% 826/842
🟢 Branches 92.96% 383/412
🟢 Functions 98.67% 223/226
🟢 Lines 98.49% 783/795

Test suite run success

247 tests passing in 10 suites.

Report generated by 🧪jest coverage report action from eae3b82

@jboix jboix force-pushed the feat/vite-migration branch from 99ae9e1 to 7670192 Compare June 10, 2024 08:07
@jboix jboix marked this pull request as ready for review October 23, 2024 08:04
Replaces Rollup and Parcel with Vite as the sole build tool in order to reduce complexity. The
changes involve:

- Removed `.parcelrc` and `rollup.config.js`, as their functionalities are now handled by Vite.
- Introduced multiple Vite config to support the various build outputs previously managed by Rollup.
- Updated `package.json` to integrate Vite dependencies and remove those related to Rollup and
  Parcel (2 Rollup plugins have been retained, including Babel to enhance browser compatibility and
  Terser for minifying the UMD build).
- Modified `scss/pillarbox.scss` to enhance compatibility with the new Vite build setup. This update
  includes simplifying SCSS imports, making it easier to resolve external dependencies without
  depending on the file's location.
- The server previously started by Parcel for the demo pages is now efficiently handled by Vite's
  native development server.
@jboix jboix force-pushed the feat/vite-migration branch from 7670192 to eae3b82 Compare October 23, 2024 08:40
Copy link
Member

@amtins amtins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Purefect thank you.

@jboix jboix merged commit 606126f into main Oct 23, 2024
5 checks passed
@jboix jboix deleted the feat/vite-migration branch October 23, 2024 14:16
Copy link

🎉 This PR is included in version 1.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants