Skip to content

Conversation

amtins
Copy link
Member

@amtins amtins commented Oct 29, 2024

Description

Resolves #265 by allowing the ADI team to measure videos played with the described audio track enabled.

Changes made

  • add a function to indicate whether the activated audio track is audio described or not
  • add an event label named media_audiodescription_on

Resolves #265 by allowing the ADI team to measure videos played with the
described audio track enabled.

- add a function to indicate whether the activated audio track is audio
described or not
- add an event label named `media_audiodescription_on`
Copy link

github-actions bot commented Oct 29, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-29 14:16 UTC

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
98.11% (+0.01% 🔼)
830/846
🟢 Branches
93% (+0.03% 🔼)
385/414
🟢 Functions
98.68% (+0.01% 🔼)
225/228
🟢 Lines
98.5% (+0.01% 🔼)
787/799

Test suite run success

247 tests passing in 10 suites.

Report generated by 🧪jest coverage report action from d0b6a27

Copy link
Member

@jboix jboix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amtins amtins merged commit cda0d7a into main Oct 29, 2024
5 checks passed
@amtins amtins deleted the feat/265-audio-description-flag-in-analytics branch October 29, 2024 14:16
Copy link

🎉 This PR is included in version 1.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Audio Description flag in analytics

2 participants