fix(media-composition): remove chapters if the media is not type of EPISODE #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PISODE Fixes #321, by removing chapters when the media type is not an episode. This follows the decision made during API discussion [#146](SRGSSR/pillarbox-documentation#146 (comment)). Since Pillarbox lacks an automatic metadata update mechanism, removing chapters helps prevent confusion when a highlight is added during a live sports event. Additionally, chapters in media types such as EXTRACT, TRAILER, and CLIP are considered a bug and should not be present. - Remove chapters if the media is not an EPISODE - Add a test case
|
Coverage report
Test suite run success249 tests passing in 10 suites. Report generated by 🧪jest coverage report action from 939f356 |
|
🎉 This PR is included in version 1.21.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #321, by removing chapters when the media type is not an episode. This follows the decision made during API discussion #146. Since Pillarbox lacks an automatic metadata update mechanism, removing chapters helps prevent confusion when a highlight is added during a live sports event.
Additionally, chapters in media types such as
EXTRACT,TRAILER, andCLIPare considered a bug and should not be present.Changes made
EPISODE