This repository was archived by the owner on Oct 15, 2019. It is now read-only.
[BSC#1111880] Change internal LDAP group name to prevent conflicts #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h conflicts The internal LDAP group name for the Velum admin user was 'Administrators'. Once external auth is enabld to a companies LDAP server, this causes anyone in an Administrators group there also to gain permission to be a cluster admin. Changing the name of the group to CaaSP-Administrators to prevent this conflict from occurring and it to be explicity obvious what the group is intended to administrate.
|
Based on a quick grep, the Otherwise, this LGTM - once you (or someone) has figured out how this gets applied to an existing cluster in an update situation and noted that either here or in the bugzilla record. :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change internal LDAP group name to prevent external auth conflicts
The internal LDAP group name for the Velum admin user was 'Administrators'. Once external auth is enabld to a companies LDAP server, this causes anyone in an Administrators group there also to gain permission to be a cluster admin.
Changing the name of the group to CaaSP-Administrators to prevent this conflict from occurring and it to be explicity obvious what the group is intended to administrate.