This repository was archived by the owner on Oct 15, 2019. It is now read-only.
[WIP] Safer DB user creation #223
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 27, 2019 20:13
If a user already exists but teh secret file has been modified, the database user's password will not be changed for an existing user. Further, the create user command will generate an error if run against a user which already exists. Separate out the user create and password set commands so the create can add the "if not exsts" option and so the password can be resync'd with the file contents.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create DB user only if user doesn't already exist, and set password based on file contents. This should help with backup/restore procedure, and generally makes more sense in that it won't generate error output in logs due to the user already existing.
Also added a couple of sanity / security checks while I was in there:
Work-in-progress while doing some additional testing