Skip to content

preRun type is incorrect #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeswr opened this issue Jan 30, 2023 · 0 comments
Open

preRun type is incorrect #13

jeswr opened this issue Jan 30, 2023 · 0 comments

Comments

@jeswr
Copy link
Collaborator

jeswr commented Jan 30, 2023

This is likely to be an upsteam issue in @types/emscripten, but I do not have the time to investigate fully right now.

Currently the type signature of preRun is (() => void)[]. Instead it should be more like

type singlePreRunType = ((arg: SWIPLModule) => void) | (() => void);
type preRunType = singlePreRunType | singlePreRunType[] | undefined;

as can be seen in the usage in https://github.com/eyereasoner/eye-js/pull/79/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant