Local Config #3103
Open
Local Config #3103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* W-19084772 Remove review order step in one click checkout * skip changelog * re work to place the Place Order button according to the latest figma * fix button stickiness
Add a new user registration ("Save for Future Use") box in the 1CC layout. After placing order with this option checked, account registration will be initiated.
Add saved phone number to the 1CC user registration flow.
Add saved shipping address to the 1CC user registration flow.
* Initial push for the demo * fix guest user flow to not show the otp modal * W-18927151 Trigger OTP modal * Reverting configuration * minor * skip changelog * fix translations * minor - remove comment * address code review comments * fix the spinner
* W-19084772 Remove review order step in one click checkout * skip changelog * re work to place the Place Order button according to the latest figma * fix button stickiness
Add a new user registration ("Save for Future Use") box in the 1CC layout. After placing order with this option checked, account registration will be initiated.
Add saved phone number to the 1CC user registration flow.
Add saved shipping address to the 1CC user registration flow.
* Initial push for the demo * fix guest user flow to not show the otp modal * W-18927151 Trigger OTP modal * Reverting configuration * minor * skip changelog * fix translations * minor - remove comment * address code review comments * fix the spinner
…3050) * add focus on the first digit in the otp modal * initial push * lint changes * revertint otp changes * remove log messages * skip changelog * add focus on the first digit in the otp modal * initial push * lint changes * revertint otp changes * remove log messages * skip changelog * lint fix after rebase
… from `develop` branch (@W-19170135@) (#3058) * Add new performance metrics workflow * Add comment * Disable some steps that are not needed * Update todos * Generate the project * Avoid dirtying workspace and remove unnecessary step * Tweak parameters * Allow for internal short codes * Align with the order of answers to the extensibility question * Create update-csp-directives.js * Rename script for clarity * Schedule it to run before the performance tests * Move constant into the config file * Move CSP directives into the config file * Make sure the corresponding .hbs files are up to date * Now scripts looks for the config file * Fix linting errors * Add auto lint fixing * For backward compatibility * New step to add CSP directives * Log where the file is at * Add a new script * Address a few todos * Allow updating property with the same value * Finish and clean up the workflow * Move scripts and remove default value for config path * No longer assume default value for config path And no longer preserving comments * No longer support null, undefined values * Delete unnecessary comments * Revert changes in retail-react-app * Create a new generator preset * Revert changes to the generator * Add csp directives to ssr.js.hbs * Update app/constants.js files to support the new preset * No longer needing these scripts * Workflow now uses the new generator preset * No need to validate app in this case * Add the preset to more files * Revert some changes and keep one change * Delete extra space * Empty commit * Simplify the handlebar template logic * No more hardcoding the `generated-projects` path * Move feature toggle for partial hydration into the config file * Remove unnecessary tests * Update CHANGELOG.md * Make sure all ssr.js related files are in sync * Fix linting error I wanted to preserve the comma at the end of the line because otherwise, I'm worried that it's easy to overlook it later. --------- Co-authored-by: Jainam Sheth <j.sheth@salesforce.com>
Signed-off-by: syadupathi-sf <66088780+syadupathi-sf@users.noreply.github.com>
* W-19251999 Resend OTP * increasing max size limit since the addition of 1CC makes it go over by 1.5KB * style update
* Extract lint and bundle size workflows * test: lower bundle size limit to test CI failure This is a minimal change to verify the new bundle-size workflow correctly fails when bundle size exceeds limits. Will be reverted. * revert: restore original bundle size limit to 62 kB Reverts the test change that lowered the bundle size limit from 62 kB to 50 kB. The CI workflow decoupling test was successful. * test: add unused variable to trigger lint error Added an unused variable to test that the lint workflow fails correctly while the test workflow continues to run independently. * fix: remove test lint error Removed the unused variable that was added to test lint workflow failure. The lint workflow decoupling test was successful. * test: add undefined variable to trigger actual lint error Added undefined variable reference that causes ESLint 'no-undef' error, not just a warning. This should cause the lint workflow to fail. * revert: restore main.jsx to original clean state Removed both the unused variable and undefined variable that were added for testing lint workflow failure. File is now back to original state. * clean: remove unused IS_NOT_FORK env variable from bundle-size workflow The IS_NOT_FORK environment variable was defined but never used in any conditional statements within the bundle-size workflow. Removing it simplifies the workflow and allows bundle size checks to run on all PRs including those from forks, which is beneficial for code quality. * clean: remove unused IS_NOT_FORK env variable from lint workflow The IS_NOT_FORK environment variable was defined but never used in any conditional statements within the lint workflow. Removing it simplifies the workflow and allows linting checks to run on all PRs including those from forks, which is beneficial for code quality.
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization