Skip to content

Conversation

sf-henry-semaganda
Copy link
Contributor

@sf-henry-semaganda sf-henry-semaganda commented Sep 25, 2025

Description

Refactored the create_page tool to eliminate 5 parameters (nodeModulesPath, componentsPath, pagesPath, routesPath, hasOverridesDir) from its interface, reducing it from 8 to 3 essential parameters.

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • Created a detectWorkspacePaths() function that automatically detects all required paths using the PWA_STOREFRONT_APP_PATH environment variable, making the tool work seamlessly across both monorepo and generated projects.

How to Test-Drive This PR

  • Build the MCP package first: cd packages/pwa-kit-mcp && npm run build
  • Test in monorepo: Use your existing MCP config with PWA_STOREFRONT_APP_PATH pointing to the monorepo app directory
  • Test in generated project: Create a new MCP config and try creating a page

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@cc-prodsec
Copy link
Collaborator

cc-prodsec commented Sep 25, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@sf-henry-semaganda sf-henry-semaganda marked this pull request as ready for review September 30, 2025 16:30
@sf-henry-semaganda sf-henry-semaganda requested a review from a team as a code owner September 30, 2025 16:30
Copy link
Contributor

@patricksullivansf patricksullivansf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but if we merge directly to develop then a changelog is required

@@ -1,3 +1,6 @@
## v0.4.0-dev (Sep 30, 2025)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be duplicate 4.0-dev entries?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants