-
Notifications
You must be signed in to change notification settings - Fork 195
@W-19624822 feat: eliminate the extra parameters exposed through create_page tool #3359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but if we merge directly to develop then a changelog is required
@@ -1,3 +1,6 @@ | |||
## v0.4.0-dev (Sep 30, 2025) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be duplicate 4.0-dev entries?
Description
Refactored the create_page tool to eliminate 5 parameters (nodeModulesPath, componentsPath, pagesPath, routesPath, hasOverridesDir) from its interface, reducing it from 8 to 3 essential parameters.
Types of Changes
Changes
detectWorkspacePaths()
function that automatically detects all required paths using thePWA_STOREFRONT_APP_PATH
environment variable, making the tool work seamlessly across both monorepo and generated projects.How to Test-Drive This PR
cd packages/pwa-kit-mcp && npm run build
PWA_STOREFRONT_APP_PATH
pointing to the monorepo app directoryChecklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization