-
Notifications
You must be signed in to change notification settings - Fork 195
@W-19758448 Create PWA-Kit MCP Rules to guide the agent into optimal tool use #3366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
fb0916c
to
472d9cb
Compare
## 🧰 Features | ||
|
||
The PWA Kit MCP Server offers the following intelligent tools tailored to Salesforce Commerce Cloud PWA development: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we're renaming these, what do you think about having "sample" in these tool names. I feel like it would be clearer if they were just create_component and create_page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patricksullivansf I agree with @shauryemahajanSF's suggestion. I suggested removing "sample" in the last round of tool name updates that @sneh171196 did. The reason for my opposition for including the word "sample" is that we aren't creating a complete sample. For example, the component created still needs the user to add property values to it for it work. Using the word "sample" is misleading because it would make people believe that they're getting the full working sample while it is not.
By the way, why is your version not showing the latest updates that Sneha did? Is this the latest branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah seems that @patricksullivansf is not on the latest develop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you mean. _sample_
is now removed tool names in this PR.
# B2C Commerce Cloud PWA-Kit Retail React Application - Agent Mandatory Tool Usage Guidelines | ||
|
||
Use these tools only when the user’s prompt clearly matches a tool’s purpose. Do not override or delay other built-in or MCP tools when these do not apply. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to consider prefixing these with pwa_
instead of b2c_
, since its more precise.
The PWA Kit MCP Server offers the following intelligent tools tailored to Salesforce Commerce Cloud PWA development: | ||
|
||
* **`create_storefront_app`**: | ||
* **`b2c_create_storefront_app`**: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be necessary to add the Salesforce company name before b2c_
? What if another company also creates an MCP server with the same b2c_
prefix? So for example, it could be sfb2c_
.
Description
Features:
Types of Changes
Changes
How to Test-Drive This PR
Follow the steps in the PWA-Kit readme for local development and deployment. Then try prompts like the following:
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization