configury: Fixed disable-rpath #1188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue Sandia-OpenSHMEM#1162 The build system relies on libtool to build libraries. libtool will insert an rpath into libraries unless you set hardcode_into_libs = no. Modified configury to set hardcode_into_libs if disable-rpath is set. Signed-off-by: Mark F. Brown <mark.f.brown@intel.com>
bcmIntc
approved these changes
Feb 28, 2025
davidozog
approved these changes
Feb 28, 2025
There was a problem hiding this comment.
This pretty much does the right thing on my end (at least locally, Ubuntu 24.04)
It has the interesting effect that pmi-simple is not found by ldd unless explicitly setting LD_LIBRARY_PATH or LD_PRELOAD, but I think that's fine... make check still works in this case, so we could add a --disable-rpath row in CI if so desired. (but maybe that's not very valuable).
Anyway, I'll keep an eye on it, but it certainly seems to fix #1162
Nice find on hardcode_into_libs @markbrown314! And thanks for the fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1162
The build system relies on libtool to build libraries. libtool will insert an rpath into libraries unless you set hardcode_into_libs = no. Modified configury to set hardcode_into_libs if disable-rpath is set.