configury: -disable-rpath carried through to tests #1195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! I did not look at the test-sos binaries. I only checked the libsma's DT_RUNPATH entry. |
markbrown314
approved these changes
Mar 18, 2025
Indeed - I can't take credit, @bcernohous noticed the issue - thanks for catching it early Bob! |
bcmIntc
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #1194.
The solution is a little strange and derived from some poorly documented features of
libtoolthat I learned about from stackoverflow - so I cite that source.It essentially adds a dummy symbol to
hardcode_libdir_flag_spec, which prevents flags like-Wl,-rpath -Wl,/path/to/libfabric/lib -Wl,-rpath -Wl,/path/to/SOS/libfrom being added to the link line for thetests-sosbinaries.