CI: Update to Ubuntu 24.04 #1203
Conversation
|
Updated CI to use Ubuntu 24.04 Unfortunately there are a few tests that now fail in CI (sometimes) which requires debug. |
markbrown314
force-pushed
the
issue-1190
branch
from
989c9b2 to
f2879a7
Compare
Issue Sandia-OpenSHMEM#1190 * Resolved build issue for Portals 4 on Ubuntu 24.04 * Portals 4 with PMI-MPI fails due to crash * Temporarily convert Portals 4 test issues to annotations Signed-off-by: Mark F. Brown <mark.f.brown@intel.com>
markbrown314
force-pushed
the
issue-1190
branch
from
f2879a7 to
3f7a16e
Compare
| run: | | ||
| cd repos/portals4 | ||
| ./autogen.sh | ||
| sed -i 's/^struct ptl_abort_state abort_state;/static struct ptl_abort_state abort_state;/' src/ib/ptl_gbl.h |
There was a problem hiding this comment.
Should we upstream this to Portals4? It's minor, so we can move forward with this fix if that process is slow or otherwise undesirable. But IIUC, we should suggest adding static here upstream in case they fiddle with variable names or something?
There was a problem hiding this comment.
@davidozog this is just a work around. I reported the issue to the Portals 4 team: sandialabs/portals4#99
I did not get a response yet. Ultimately the problem is that a global variable is being declared in a header file. Which causes the variable to be defined multiple times which causes a linking conflict. The solution would be to declare it in one of the C files, but I am not that familiar with the code base, so I figured it would be better for them to make that choice.
3 participants
Issue #1190