Fixed SHMEM_SYMMETRIC_SIZE #1216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @markbrown314, apologies for the tag. |
|
Thanks! I will take a look at as soon as I can. |
markbrown314
requested changes
Aug 25, 2025
There was a problem hiding this comment.
Thanks for the commit. Please clean up the commit message. Here is an example you can use:
Improved SHMEM_SYMMETRIC_SIZE Validation
Issue #1185
If SHMEM_SYMMETRIC_SIZE contains invalid characters, return error.
Signed-off by: Your Real Name <email address>
It would be best if your signed off name be your real name rather than a pseudonym. As well as the Author Name (user.name git config).
src/shmem_env.c
Outdated
|
|
||
| n = sscanf(str, "%lf%c", &p, &f); | ||
| if (2 == sscanf(str, "%lf%c%n", &p, &f, &n)) { | ||
| if (str[n] != '\0') { exit(1); } |
There was a problem hiding this comment.
You need to return 1 rather than exit(1)
When the atol_scaled() returns a non-zero value it prints "Invalid size in environment variable" to user. Exit will just shut it down abruptly.
300degree
force-pushed
the
fix/T-1185-symmetric-size-env-validation
branch
from
9d4acf4 to
3a241fd
Compare
Issue Sandia-OpenSHMEM#1185 If SHMEM_SYMMETRIC_SIZE contains invalid characters, return error. Signed-off-by: Kitibodee Phuphanwoe <kitibodee.ph@ksu.ac.th>
300degree
force-pushed
the
fix/T-1185-symmetric-size-env-validation
branch
from
3a241fd to
389f4f8
Compare
|
The previous one was mistyped. I forgot to use |
markbrown314
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i inspired by OpenMPI
#1185