-
Notifications
You must be signed in to change notification settings - Fork 16
1242 update simple surrogate model #1252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i had a first brief look at most of the secir_simple functions. Lets discuss the points before you start working on this :) Looks really good, great work :)
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_simple/data_generation.py
Outdated
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_simple/data_generation.py
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_simple/data_generation.py
Outdated
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_simple/data_generation.py
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_simple/grid_search.py
Outdated
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_simple/grid_search.py
Outdated
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_simple/hyperparameter_tuning.py
Outdated
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_simple/hyperparameter_tuning.py
Outdated
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_simple/hyperparameter_tuning.py
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_simple/hyperparameter_tuning.py
Show resolved
Hide resolved
Co-authored-by: Henrik Zunker <69154294+HenrZu@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work :) Some more comments. Regarding the ones about the secir groups. We can skip them and adress them in the next pull request since we only wanted to deal with the secir simple one and still need to rework the groups one.
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_groups/model.py
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_groups/model.py
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_groups/model.py
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_groups/model.py
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_groups/model.py
Show resolved
Hide resolved
...e/memilio-surrogatemodel/memilio/surrogatemodel_test/test_surrogatemodel_ode_secir_simple.py
Outdated
Show resolved
Hide resolved
...e/memilio-surrogatemodel/memilio/surrogatemodel_test/test_surrogatemodel_ode_secir_simple.py
Show resolved
Hide resolved
...e/memilio-surrogatemodel/memilio/surrogatemodel_test/test_surrogatemodel_ode_secir_simple.py
Outdated
Show resolved
Hide resolved
...e/memilio-surrogatemodel/memilio/surrogatemodel_test/test_surrogatemodel_ode_secir_simple.py
Outdated
Show resolved
Hide resolved
...e/memilio-surrogatemodel/memilio/surrogatemodel_test/test_surrogatemodel_ode_secir_groups.py
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1252 +/- ##
==========================================
- Coverage 97.23% 97.21% -0.03%
==========================================
Files 155 167 +12
Lines 14278 14960 +682
==========================================
+ Hits 13883 14543 +660
- Misses 395 417 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_simple/network_architectures.py
Outdated
Show resolved
Hide resolved
This also closes #849 |
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)