Skip to content

1242 update simple surrogate model #1252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Jun 4, 2025
Merged

Conversation

mhheger
Copy link
Contributor

@mhheger mhheger commented Apr 16, 2025

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • restructuring the existing code for simple surrogate models
  • adding tests

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@HenrZu HenrZu linked an issue Apr 16, 2025 that may be closed by this pull request
2 tasks
Copy link
Contributor

@HenrZu HenrZu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i had a first brief look at most of the secir_simple functions. Lets discuss the points before you start working on this :) Looks really good, great work :)

Copy link
Contributor

@HenrZu HenrZu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work :) Some more comments. Regarding the ones about the secir groups. We can skip them and adress them in the next pull request since we only wanted to deal with the secir simple one and still need to rework the groups one.

Copy link

codecov bot commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.21%. Comparing base (12b041d) to head (a3ef9e2).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1252      +/-   ##
==========================================
- Coverage   97.23%   97.21%   -0.03%     
==========================================
  Files         155      167      +12     
  Lines       14278    14960     +682     
==========================================
+ Hits        13883    14543     +660     
- Misses        395      417      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HenrZu
Copy link
Contributor

HenrZu commented Jun 4, 2025

This also closes #849

@HenrZu HenrZu linked an issue Jun 4, 2025 that may be closed by this pull request
2 tasks
@HenrZu HenrZu merged commit d1b66f3 into main Jun 4, 2025
108 of 110 checks passed
@HenrZu HenrZu deleted the 1242-update-simple-surrogate-model branch June 4, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Simple surrogate model Grid Search for simple models for one population
2 participants