-
Notifications
You must be signed in to change notification settings - Fork 20
1246 Export TimeSeries into csv file #1255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1255 +/- ##
=======================================
Coverage 97.21% 97.21%
=======================================
Files 167 167
Lines 14950 14960 +10
=======================================
+ Hits 14533 14543 +10
Misses 417 417 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
reneSchm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, needs a few minor changes, and a comment per test that briefly describes what is tested (so other devs know why the test exists and what result is expected).
Co-authored-by: reneSchm <49305466+reneSchm@users.noreply.github.com>
reneSchm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The coverage -.03% is annoying, can you try merging main? Codecov compares against an older commit, so maybe that helps?
Otherwise just some small suggestions left.
Co-authored-by: reneSchm <49305466+reneSchm@users.noreply.github.com>
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)