Skip to content

Add package quality tests #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Apr 29, 2025
Merged

Add package quality tests #300

merged 23 commits into from
Apr 29, 2025

Conversation

ErikQQY
Copy link
Member

@ErikQQY ErikQQY commented Apr 3, 2025

Add Aqua and JET package quality tests

Copy link
Contributor

github-actions bot commented Apr 3, 2025

Benchmark Results

master 3e8a58f... master / 3e8a58f...
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK2() 8.03 ± 0.32 ms 7.73 ± 0.2 ms 1.04
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK3() 2.93 ± 0.22 ms 2.89 ± 0.22 ms 1.01
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK4() 1.01 ± 0.11 ms 0.995 ± 0.084 ms 1.02
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK5() 2.62 ± 0.48 ms 2.56 ± 0.49 ms 1.02
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK6() 1.2 ± 0.22 ms 1.17 ± 0.18 ms 1.03
Simple Pendulum/IIP/MultipleShooting(10, Tsit5; grid_coarsening = false) 1.95 ± 0.67 ms 1.88 ± 0.69 ms 1.03
Simple Pendulum/IIP/MultipleShooting(10, Tsit5; grid_coarsening = true) 3.2 ± 1.1 ms 3.17 ± 1.2 ms 1.01
Simple Pendulum/IIP/MultipleShooting(100, Tsit5; grid_coarsening = false) 0.0747 ± 0.02 s 0.0718 ± 0.02 s 1.04
Simple Pendulum/IIP/MultipleShooting(100, Tsit5; grid_coarsening = true) 0.0898 ± 0.022 s 0.0858 ± 0.023 s 1.05
Simple Pendulum/IIP/Shooting(Tsit5()) 0.268 ± 0.084 ms 0.266 ± 0.082 ms 1.01
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK2() 9.69 ± 0.65 ms 9.2 ± 0.36 ms 1.05
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK3() 3.44 ± 0.29 ms 3.36 ± 0.22 ms 1.02
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK4() 1.19 ± 0.12 ms 1.17 ± 0.1 ms 1.01
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK5() 3.06 ± 0.61 ms 3.01 ± 0.63 ms 1.02
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK6() 1.42 ± 0.19 ms 1.41 ± 0.19 ms 1.01
Simple Pendulum/OOP/MultipleShooting(10, Tsit5; grid_coarsening = false) 3.69 ± 3 ms 3.56 ± 3.1 ms 1.04
Simple Pendulum/OOP/MultipleShooting(10, Tsit5; grid_coarsening = true) 6.16 ± 5.2 ms 5.87 ± 6.2 ms 1.05
Simple Pendulum/OOP/MultipleShooting(100, Tsit5; grid_coarsening = false) 0.133 ± 0.022 s 0.126 ± 0.022 s 1.06
Simple Pendulum/OOP/MultipleShooting(100, Tsit5; grid_coarsening = true) 0.163 ± 0.03 s 0.153 ± 0.029 s 1.07
Simple Pendulum/OOP/Shooting(Tsit5()) 0.657 ± 0.074 ms 0.654 ± 0.054 ms 1
time_to_load 5.18 ± 0.011 s 5.06 ± 0.012 s 1.03

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@ErikQQY ErikQQY closed this Apr 4, 2025
@ErikQQY ErikQQY reopened this Apr 4, 2025
@ErikQQY
Copy link
Member Author

ErikQQY commented Apr 8, 2025

Seems good to go now, will merge when all CIs are happy

@ErikQQY
Copy link
Member Author

ErikQQY commented Apr 9, 2025

OK, seems OrdinaryDiffEq still need some thing for the ForwardDiff 1.0 support, let's wait SciML/OrdinaryDiffEq.jl#2643

Let's not use ForwardDiff 1.0 for now

@ErikQQY ErikQQY merged commit 177cf41 into SciML:master Apr 29, 2025
27 of 29 checks passed
@ErikQQY ErikQQY deleted the qqy/quality branch April 29, 2025 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant