Skip to content

Set strict to false in shooting when prepare jacobian #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025
Merged

Conversation

ErikQQY
Copy link
Member

@ErikQQY ErikQQY commented May 13, 2025

Adapt to DifferentiationInterface 0.7.0 breaking change.

Copy link
Contributor

github-actions bot commented May 13, 2025

Benchmark Results

master 8606d36... master / 8606d36...
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK2() 0.646 ± 0.016 s 0.616 ± 0.022 s 1.05 ± 0.046
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK3() 14.5 ± 0.79 ms 14.1 ± 0.58 ms 1.02 ± 0.07
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK4() 3.24 ± 0.21 ms 3.24 ± 0.2 ms 1 ± 0.09
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK5() 9.76 ± 1.3 ms 9.61 ± 1.3 ms 1.02 ± 0.19
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK6() 1.68 ± 0.3 ms 1.66 ± 0.3 ms 1.01 ± 0.26
Simple Pendulum/IIP/MultipleShooting(10, Tsit5; grid_coarsening = false) 1.86 ± 0.66 ms 1.85 ± 0.68 ms 1 ± 0.51
Simple Pendulum/IIP/MultipleShooting(10, Tsit5; grid_coarsening = true) 3.14 ± 1 ms 3.16 ± 1 ms 0.996 ± 0.45
Simple Pendulum/IIP/MultipleShooting(100, Tsit5; grid_coarsening = false) 0.0664 ± 0.012 s 0.0663 ± 0.0082 s 1 ± 0.22
Simple Pendulum/IIP/MultipleShooting(100, Tsit5; grid_coarsening = true) 0.0791 ± 0.017 s 0.0788 ± 0.022 s 1 ± 0.35
Simple Pendulum/IIP/Shooting(Tsit5()) 0.253 ± 0.08 ms 0.248 ± 0.077 ms 1.02 ± 0.45
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK2() 0.744 ± 0.013 s 0.758 ± 0.013 s 0.981 ± 0.024
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK3() 17 ± 4.6 ms 17 ± 4.5 ms 1 ± 0.38
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK4() 3.72 ± 0.18 ms 3.71 ± 0.16 ms 1 ± 0.065
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK5() 11 ± 2 ms 11.1 ± 2 ms 0.994 ± 0.26
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK6() 1.93 ± 0.18 ms 1.92 ± 0.18 ms 1 ± 0.13
Simple Pendulum/OOP/MultipleShooting(10, Tsit5; grid_coarsening = false) 3.52 ± 3 ms 3.52 ± 2.9 ms 1 ± 1.2
Simple Pendulum/OOP/MultipleShooting(10, Tsit5; grid_coarsening = true) 5.96 ± 5.1 ms 6 ± 5.1 ms 0.993 ± 1.2
Simple Pendulum/OOP/MultipleShooting(100, Tsit5; grid_coarsening = false) 0.116 ± 0.0094 s 0.115 ± 0.022 s 1.01 ± 0.21
Simple Pendulum/OOP/MultipleShooting(100, Tsit5; grid_coarsening = true) 0.143 ± 0.03 s 0.142 ± 0.017 s 1.01 ± 0.24
Simple Pendulum/OOP/Shooting(Tsit5()) 0.638 ± 0.05 ms 0.634 ± 0.046 ms 1.01 ± 0.11
time_to_load 5.05 ± 0.025 s 5.03 ± 0.0076 s 1 ± 0.0052

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@ErikQQY
Copy link
Member Author

ErikQQY commented May 13, 2025

Tests for shooting methods are using DifferentiationInterface@0.7.0, and CIs are happy about it, let's go!

@ErikQQY ErikQQY merged commit 343f87f into master May 13, 2025
12 checks passed
@ErikQQY ErikQQY deleted the qqy/di_strict branch May 13, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant