Skip to content

Commit 005799c

Browse files
authored
Merge pull request #1244 from AayushSabharwal/as/unbroken-test
test: broken test is now fixed
2 parents b07c380 + 2ef50c4 commit 005799c

File tree

4 files changed

+5
-4
lines changed

4 files changed

+5
-4
lines changed

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ LaTeXStrings = "1.3.0"
6262
Latexify = "0.16.6"
6363
MacroTools = "0.5.5"
6464
Makie = "0.22.1"
65-
ModelingToolkit = "9.69"
65+
ModelingToolkit = "9.73"
6666
NetworkLayout = "0.4.7"
6767
Parameters = "0.12"
6868
Reexport = "1.0"

test/simulation_and_solving/hybrid_models.jl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -324,9 +324,10 @@ let
324324

325325
# Checks case: X Float32 (non-default float), Y Float32 (non-default). Everything is converted to Float32.
326326
u0 = (:X => 1.0f0, :Y => 1.0f0)
327+
ps = [:d => 0.5f0]
327328
prob = JumpProblem(JumpInputs(rn, u0, (0.0, 1.0), ps; remake_warn = false))
328329
int = init(prob, Tsit5())
329330
sol = solve(prob, Tsit5())
330331
@test typeof(prob[:X]) == typeof(int[:X]) == typeof(sol[:X][end]) == Float32
331332
@test typeof(prob[:Y]) == typeof(int[:Y]) == typeof(sol[:Y][end]) == Float32
332-
end
333+
end

test/simulation_and_solving/simulate_ODEs.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ let
193193
ps = [:k1 => 2.0f0, :k2 => 3.0f0]
194194
oprob = ODEProblem(rn, u0, 1.0f0, ps)
195195
osol = solve(oprob, Tsit5())
196-
@test_broken eltype(osol[:X1]) == eltype(osol[:X2]) == typeof(oprob[:X1]) == typeof(oprob[:X2]) == Float32 # https://github.com/SciML/ModelingToolkit.jl/issues/3553
196+
@test eltype(osol[:X1]) == eltype(osol[:X2]) == typeof(oprob[:X1]) == typeof(oprob[:X2]) == Float32
197197
@test eltype(osol.t) == typeof(oprob.tspan[1]) == typeof(oprob.tspan[2]) == Float32
198198
end
199199

test/simulation_and_solving/simulate_SDEs.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -413,7 +413,7 @@ let
413413
ps = [:k1 => 2.0f0, :k2 => 3.0f0]
414414
sprob = SDEProblem(rn, u0, 1.0f0, ps)
415415
ssol = solve(sprob, ISSEM())
416-
@test_broken eltype(ssol[:X1]) == eltype(ssol[:X2]) == typeof(sprob[:X1]) == typeof(sprob[:X2]) == Float32
416+
@test eltype(ssol[:X1]) == eltype(ssol[:X2]) == typeof(sprob[:X1]) == typeof(sprob[:X2]) == Float32
417417
@test eltype(ssol.t) == typeof(sprob.tspan[1]) == typeof(sprob.tspan[2]) == Float32
418418
end
419419

0 commit comments

Comments
 (0)