Skip to content

Tests failing for prerelease #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
isaacsas opened this issue Apr 14, 2025 · 8 comments
Open

Tests failing for prerelease #1235

isaacsas opened this issue Apr 14, 2025 · 8 comments
Labels

Comments

@isaacsas
Copy link
Member

We need to investigate this and see if the issue is Catalyst related or not.

@isaacsas isaacsas added the bug label Apr 14, 2025
@ChrisRackauckas
Copy link
Member

I wouldn't worry about it yet. I think it's a bug in the prerelease that is breaking some world age behavior due to some changes in globals. I'll need to talk with @oscardssmith about that.

@isaacsas
Copy link
Member Author

Ok, thanks for letting us know.

@oscardssmith
Copy link
Member

yeah it is a change in globals. 1.12 got a tiny bit stricter in ways that pretty much only affect code that was slightly weird/broken which given the amount of code we have, it isn't exactly surprising that we have some of it.

@ChrisRackauckas
Copy link
Member

Some of it could be things we need to change, but other things may just be accidental breaking changes in the Julia compiler that we need to notify get fixed during the beta stage 😅 . You can be the arbiter of which is which. Let's walk through that in one of the Monday calls since I assume some of these might need discussion (I see RuntimeGeneratedFunctions popping up)

@ChrisRackauckas
Copy link
Member

Let's just keep this to the issue SciML/RuntimeGeneratedFunctions.jl#95 (comment)

ChrisRackauckas added a commit that referenced this issue Apr 22, 2025
This should be at least a partial fix to #1235, but may also need  SciML/RuntimeGeneratedFunctions.jl#96 to fully get pre working
@ChrisRackauckas
Copy link
Member

It looks like we know what the RGF one is, but the Catalyst one looks like it's just incorrect macro code.

ex = Catalyst.__unpacksys($(esc(rn)))
Base.eval($(__module__), ex)

You should never use eval in a macro. The rule is that if you use eval in a macro is probably wrong 😅.

@isaacsas
Copy link
Member Author

That was an internal hack to allow unpacking all the Symbolics in a model, and was never exported or advertised/made api. It really isn’t needed anymore now that Symbol-based indexing generally works, so we should just remove it.

@ChrisRackauckas
Copy link
Member

That would be best, because it seems like it's just not going to be easy to support that in Julia v1.12 as it's doing some odd writing to modules at eval time. Working around it seems like a bit more work and is likely not very reliable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants