-
-
Notifications
You must be signed in to change notification settings - Fork 79
New functionality planning #1264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I believe it would be great to add optional compartment (e.g. cytosol and nucleus volumes). Manually handling compartment scaling is easy to get wrong, and compartments are among the few SBML features still missing in Catalyst.jl, so adding support would in the future make it easier to write a
For this it could be worthwhile to glance at the stochastic SBML test-suite that covers many cases relevant for Catalyst. |
Do you have any material / thoughts on how compartments should be included? What changes should |
I think we had some discussion about compartments and volumes at some point a while ago. I don't remember exactly how it went, but I thin the conclusion was "This is something that we would want to have, but actually, how to implement it is not as obvious as one would immediately think". At some point we should sit down again and think through if there is a good solution (or if not, what is the best non-ideal solution). |
I agree with Torkel that compartments is something that needs to be thought about carefully (from implementing SBMLImporter I encountered many edge cases). But, I think it would be best to implement them in a similar way to SBML:
I think it is also worthwhile to consider if compartments make sense for discrete |
I thinkl one thing we discussed was how this ties into hierarchical reaction systems. I.e. it would make sense to enforce a single reaction system to be maximally one compartment, and then compose these to make multi-comaprtment models. But then you have cross compartment reactions. I have forgotten exactly how far we got, by I remember that it really wasn't obvious. |
Here are some natural questions/complexities that compartments then introduce:
|
Probably not, as this is not the SBML case
No, each specie would have a compartment, and splitting RNA into species like into nuclear and cytosol is more clear. We would have to work out the scaling math also, as for besides import or export reactions, the scaling is a bit more tricky (e.g. when a nuclear protein aids importing RNA). Compartments tied to species also means reactions per say are not tied to compartments (which I think would be the most easy solution)
How about, model with compartments is assumed to be concentration? As for events, a special class would likelly be best as here we also have the question priority, is volume changed before we also potentially change a specie? |
Uh oh!
There was an error while loading. Please reload this page.
Now that we have things working well again let's brainstorm what our next functionality efforts should be:
Docs:
The text was updated successfully, but these errors were encountered: