Fix documentation building #534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this may not be the correct thing to do, but parameters inside a DataDrivenProblem do not seem to be really used at the moment
This may not be the right thing to do
docs/make.jl
Outdated
| dev_subpkg("DataDrivenSparse") | ||
| dev_subpkg("DataDrivenSR") | ||
|
|
||
| Pkg.precompile() |
Member
There was a problem hiding this comment.
This shouldn't be necessary?
Contributor
Author
There was a problem hiding this comment.
Just slightly faster to precompile everything in parallel, instead of doing it piecewise during the next using statements. But definetely not strictly necessary.
Member
There was a problem hiding this comment.
Parallel precompilation on using should be available on recent julia versions (1.10+ or even earlier).
lcontento
commented
May 20, 2025
Co-authored-by: Lorenzo Contento <16554887+lcontento@users.noreply.github.com>
Member
|
Thanks! This is looking in a good spot again. I'll probably be setting up a new student with this soon... lots to do here. |
Contributor
Author
|
No problem! And thanks for the MTK-related finishing touches! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I tried to fix the documentation workflow.
However, there are some problems linked to MTK 9 that are not caught by the tests but appear in one tutorial.
I tried fixing a couple of them in commits b1f3ca7 and 2f50525, but since I am not familiar with MTK my fixes may not be correct.
Tests and docs should build now, but there may be more MTK-related fixes required.
I don't know when I will have time to continue working on this; I made this PR in case someone else would like to build on it.