Skip to content

Fix symbolic to numeric conversion in get_parameter_values (#559) #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix symbolic to numeric conversion in get_parameter_values (#559) #560

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions src/basis/type.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,11 +532,14 @@ This extends `getmetadata` in a way that all parameters have a numeric value.
"""
function get_parameter_values(x::Basis)
map(parameters(x)) do p
if hasmetadata(p, Symbolics.VariableDefaultValue)
return Symbolics.getdefaultval(p)
val = if hasmetadata(p, Symbolics.VariableDefaultValue)
Symbolics.getdefaultval(p)
else
return zero(Symbolics.symtype(p))
zero(Symbolics.symtype(p))
end
# Convert symbolic values to numeric values for use in ODEProblem
# This handles cases where default values are stored as Num types
return val isa Num ? Float64(val) : Float64(val)
end
end

Expand All @@ -552,11 +555,15 @@ This extends `getmetadata` in a way that all parameters have a numeric value.
"""
function get_parameter_map(x::Basis)
map(parameters(x)) do p
if hasmetadata(p, Symbolics.VariableDefaultValue)
return p => Symbolics.getdefaultval(p)
val = if hasmetadata(p, Symbolics.VariableDefaultValue)
Symbolics.getdefaultval(p)
else
return p => zero(Symbolics.symtype(p))
zero(Symbolics.symtype(p))
end
# Convert symbolic values to numeric values for use in ODEProblem
# This handles cases where default values are stored as Num types
numeric_val = val isa Num ? Float64(val) : Float64(val)
return p => numeric_val
end
end

Expand Down
Loading