Cleanup event finding and change nudging condition#1260
Merged
ChrisRackauckas merged 4 commits intoSciML:masterfrom Feb 4, 2026
Merged
Cleanup event finding and change nudging condition#1260ChrisRackauckas merged 4 commits intoSciML:masterfrom
ChrisRackauckas merged 4 commits intoSciML:masterfrom
Conversation
Member
|
Draft? |
Contributor
Author
|
I'll update the doc for |
Member
update those, downstream now handles that so it just needs to be set to passing. we will need to see downstream tests because they have a lot of callback stuff |
devmotion
reviewed
Jan 20, 2026
Contributor
Author
|
Can this be merged or is there some other issues ? |
Member
|
This seemed to have some uncaught downstream consequences:
I can handle the GPU things, that's from using non-public API in DiffEqGPU. But the MWE @AayushSabharwal found seems more central as a repeat callback detection failure. I think because of how much stuff looks breaking right now, it might be good to revert, figure out the repeat callback, and then re-merge, and I'll get the GPU update setup and ready for that. @dcourteville can you look into that repeat callback issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While implementing the change in nudging condition for #1245, I somehow ended up cleaning up all the event finding code to remove the redundant computations and useless branches, and factorize some code between ContinuousCallback and VectorContinuousCallback. If I didn't break anything it should make maintaining the code easier.
I know I shouldn't make two changes in one PR, I can split into two PR if its an issue.