Skip to content

Add LinearSolvePyAMG sub-library with PyAMG integration and tests#900

Merged
ChrisRackauckas merged 5 commits intoSciML:mainfrom
AJ0070:fix-372
Feb 28, 2026
Merged

Add LinearSolvePyAMG sub-library with PyAMG integration and tests#900
ChrisRackauckas merged 5 commits intoSciML:mainfrom
AJ0070:fix-372

Conversation

@AJ0070
Copy link
Contributor

@AJ0070 AJ0070 commented Feb 23, 2026

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Changes

  • lib/LinearSolvePyAMG/ : new sub-library (Project.toml, CondaPkg.toml, src/, test/)
  • docs/src/basics/Preconditioners.md : replaced stale cortner/PyAMG.jl entry
  • docs/src/solvers/solvers.md : added ### LinearSolvePyAMG.jl section
  • test/basictests.jl : added opt-in @static if isdefined(...) test block
  • .gitignore : added .CondaPkg/

Implemented as a sub-library (like lib/LinearSolveAutotune/) rather than a weak dependency because PyAMG is not in the Julia General registry.

Resolves #372

AI disclosure: used claude and gemini to help in replicating structure of LinearSolveAutotune in LinearSolvePyAMG, adding comments and refactoring documentation.

@AJ0070
Copy link
Contributor Author

AJ0070 commented Feb 23, 2026

I created a separate test group for PyAMG to prevent the extra setup time from installing Python and PyAMG from slowing down every Core CI job. If there is a better way to handle this, I would appreciate your thoughts @ChrisRackauckas.

@ChrisRackauckas
Copy link
Member

No AI was used at all?

@AJ0070
Copy link
Contributor Author

AJ0070 commented Feb 23, 2026

Sorry, I missed it. I have added it now and will keep it in mind to include it.

@AJ0070
Copy link
Contributor Author

AJ0070 commented Feb 27, 2026

Are there any blockers with this?

@AJ0070
Copy link
Contributor Author

AJ0070 commented Feb 27, 2026

@ChrisRackauckas

@ChrisRackauckas
Copy link
Member

Just the naming fix

@AJ0070
Copy link
Contributor Author

AJ0070 commented Feb 28, 2026

fixed it

@ChrisRackauckas ChrisRackauckas merged commit 531236f into SciML:main Feb 28, 2026
176 of 183 checks passed
@AJ0070
Copy link
Contributor Author

AJ0070 commented Feb 28, 2026

@ChrisRackauckas are there any other high priority issues you would suggest I focus on?

@ChrisRackauckas
Copy link
Member

In the same vein, #170, #47, #182, and #51

#70 would then be a good direction to go for a bit.

Then #143 #487 #561 tackling EigenProblem would be a longer term but major direction to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PyAMG.jl wrapper

2 participants