Skip to content

Optimisers iteration count should be calculated with epochs and data both #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2024
Merged

Optimisers iteration count should be calculated with epochs and data both #830

merged 1 commit into from
Sep 25, 2024

Conversation

@Vaibhavdixit02
Copy link
Member

@Vaibhavdixit02 Vaibhavdixit02 commented Sep 24, 2024

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Fixes #829
Add any other context about the problem here.

@Vaibhavdixit02 Vaibhavdixit02 mentioned this pull request Sep 24, 2024
Closed
@Vaibhavdixit02 Vaibhavdixit02 merged commit 3b8f66e into master Sep 25, 2024
@Vaibhavdixit02 Vaibhavdixit02 deleted the Vaibhavdixit02-patch-1 branch September 25, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Questions regarding new update

2 participants

@Vaibhavdixit02