Skip to content

Optimisers iteration count should be calculated with epochs and data both #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Optimisers iteration count should be calculated with epochs and data both #830

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/OptimizationOptimisers/src/OptimizationOptimisers.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ function SciMLBase.__solve(cache::OptimizationCache{

t0 = time()
Optimization.@withprogress cache.progress name="Training" begin
for _ in 1:maxiters
for epoch in 1:maxiters
for (i, d) in enumerate(data)
if cache.f.fg !== nothing && dataiterate
x = cache.f.fg(G, θ, d)
Expand All @@ -93,7 +93,7 @@ function SciMLBase.__solve(cache::OptimizationCache{
cache.f.grad(G, θ)
x = cache.f(θ)
end
opt_state = Optimization.OptimizationState(iter = i,
opt_state = Optimization.OptimizationState(iter = i + (epoch-1)*length(data),
u = θ,
objective = x[1],
grad = G,
Expand Down