use StaticW more often #2295
Merged
use StaticW more often #2295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs tests |
|
Don't existing tests cover this? What additional test would you like to see? |
|
It would be good to confirm that an existing test does indeed hit this |
| which we just added hits it. |
|
Alright then merge if tests pass |
|
interesting... there is an explicit test that |
|
Legacy. That can be removed if we see the Static operator is a faster approach |
|
test removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as pointed out by @ChrisRackauckas in #2291, we should at least try this for the non-Rosenbrock solvers.