Changed trait constraints to solve.jl for calculation of gradients, hessians and more. #651 #659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #659 +/- ##
==========================================
+ Coverage 31.29% 34.78% +3.48%
==========================================
Files 55 55
Lines 4358 4905 +547
==========================================
+ Hits 1364 1706 +342
- Misses 2994 3199 +205 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Vaibhav Kumar Dixit <vaibhavyashdixit@gmail.com>
updated error messages.
src/solve.jl
Outdated
| @@ -116,6 +116,14 @@ function _check_opt_alg(prob::OptimizationProblem, alg; kwargs...) | |||
| throw(IncompatibleOptimizerError("The algorithm $(typeof(alg)) requires constraints, pass them with the `cons` kwarg in `OptimizationFunction`.")) | |||
| !allowscallback(alg) && haskey(kwargs, :callback) && | |||
| throw(IncompatibleOptimizerError("The algorithm $(typeof(alg)) does not support callbacks, remove the `callback` keyword argument from the `solve` call.")) | |||
| !requiresgradient(alg) && !(prob.f::OptimizationFunction) && | |||
There was a problem hiding this comment.
Suggested change
| !requiresgradient(alg) && !(prob.f::OptimizationFunction) && | |
| !requiresgradient(alg) && !(prob.f isa OptimizationFunction) && |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.