Skip to content

Changed trait constraints to solve.jl for calculation of gradients, hessians and more. #651 #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 19, 2024
Merged

Changed trait constraints to solve.jl for calculation of gradients, hessians and more. #651 #659

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
499ad94
Update solve.jl
ParasPuneetSingh Apr 4, 2024
faf258d
Update src/solve.jl
ParasPuneetSingh Apr 9, 2024
807a5a6
Update solve.jl
ParasPuneetSingh Apr 9, 2024
caafb86
changed type error message.
ParasPuneetSingh Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/solve.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,14 @@ function _check_opt_alg(prob::OptimizationProblem, alg; kwargs...)
throw(IncompatibleOptimizerError("The algorithm $(typeof(alg)) requires constraints, pass them with the `cons` kwarg in `OptimizationFunction`."))
!allowscallback(alg) && haskey(kwargs, :callback) &&
throw(IncompatibleOptimizerError("The algorithm $(typeof(alg)) does not support callbacks, remove the `callback` keyword argument from the `solve` call."))
!requiresgradient(alg) && !(prob.f::OptimizationFunction) &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
!requiresgradient(alg) && !(prob.f::OptimizationFunction) &&
!requiresgradient(alg) && !(prob.f isa OptimizationFunction) &&

throw(IncompatibleOptimizerError("The algorithm $(typeof(alg)) requires gradients, pass them in `OptimizationFunction`."))
!requireshessian(alg) && !(prob.f::OptimizationFunction) &&
throw(IncompatibleOptimizerError("The algorithm $(typeof(alg)) requires hessians, pass them in `OptimizationFunction`."))
!requiresconsjac(alg) && !(prob.f::OptimizationFunction) &&
throw(IncompatibleOptimizerError("The algorithm $(typeof(alg)) requires constraint jacobian, pass them with the `cons` kwarg in `OptimizationFunction`."))
!requiresconshess(alg) && !(prob.f::OptimizationFunction) &&
throw(IncompatibleOptimizerError("The algorithm $(typeof(alg)) requires constraint hessian, pass them with the `cons` kwarg in `OptimizationFunction`."))
return
end

Expand Down