-
-
Notifications
You must be signed in to change notification settings - Fork 99
More JumpProcess benchmarks #1269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The data files which define the two new benchmarks are missing. |
Two failures to handle. Maybe for one of those make failures drop from the results? |
|
To be honest I've forgotten the details of what I was doing here, will look into it |
```julia | ||
tf = 10. | ||
rng = StableRNG(53124) | ||
algs = [NRM(), CCNRM(), DirectCR(), RSSACR()] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@isaacsas is it a fundamental limitation that CCNRM
only works with Ints`?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, the only difference from regular NRM is what data structure you use to store the next reaction times
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn’t be a methodological limitation as far as I am aware. Not sure if there could be a practical implementation issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this or the BCR examples will run with CCNRM without that. So I guess just remove from the list for now and come back to adding them?
BCR segfaults |
I somehow managed to erase the old changes when I rebased #1094 so this is a clean branch.