Skip to content

More JumpProcess benchmarks #1269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

More JumpProcess benchmarks #1269

wants to merge 8 commits into from

Conversation

vyudu
Copy link
Member

@vyudu vyudu commented Jun 2, 2025

I somehow managed to erase the old changes when I rebased #1094 so this is a clean branch.

@ChrisRackauckas
Copy link
Member

The data files which define the two new benchmarks are missing.

@ChrisRackauckas
Copy link
Member

Error: InexactError: Int64(299717.8348854)

Error: UndefVarError: end_time not defined

Two failures to handle. Maybe for one of those make failures drop from the results?

@ChrisRackauckas
Copy link
Member

BCR(Y188_Y199~0,Y196_Y207~0) 2.997178348854e+05 the starting value in BCR isn't an integer. Are you sure this isn't just written for ODEs as concentration values?

@vyudu
Copy link
Member Author

vyudu commented Jun 19, 2025

BCR(Y188_Y1990,Y196_Y2070) 2.997178348854e+05 the starting value in BCR isn't an integer. Are you sure this isn't just written for ODEs as concentration values?

To be honest I've forgotten the details of what I was doing here, will look into it

```julia
tf = 10.
rng = StableRNG(53124)
algs = [NRM(), CCNRM(), DirectCR(), RSSACR()]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isaacsas is it a fundamental limitation that CCNRM only works with Ints`?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, the only difference from regular NRM is what data structure you use to store the next reaction times

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn’t be a methodological limitation as far as I am aware. Not sure if there could be a practical implementation issue.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this or the BCR examples will run with CCNRM without that. So I guess just remove from the list for now and come back to adding them?

@ChrisRackauckas
Copy link
Member

BCR segfaults

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants