-
-
Notifications
You must be signed in to change notification settings - Fork 99
Improve CUTEst benchmarks #1283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arnavk23
wants to merge
15
commits into
SciML:cutest
Choose a base branch
from
arnavk23:my-cutest-work
base: cutest
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+711
−83
Open
Changes from 3 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
464694b
omjulia
arnavk23 1c5e355
Update Manifest.toml
arnavk23 865b25b
manifest
arnavk23 5dff3e9
formatted using JuliaFormatter
arnavk23 1ca3b09
removing deprecated CUTEst.select
arnavk23 de171d3
Update Project.toml
arnavk23 f120007
safe_solvers
arnavk23 2a12062
Update update.jl
arnavk23 4ab2f11
Update make.jl
arnavk23 28a035d
Update pages.jl
arnavk23 0056c1b
Update SciMLBenchmarks.jl
arnavk23 5002f1c
Improve CUTEst benchmarks with chunked processing and robust error ha…
arnavk23 923e3a1
Make CUTEst benchmarks extremely conservative to prevent OOM
arnavk23 544f5a2
Fix CUTEst benchmark filtering and timeout issues
arnavk23 c02c978
changes
arnavk23 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is openmodelica here?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as the error on Vaibhav's pr is the error on (IJulia, SciMLBenchmark, OMJulia, Plot) and OMJulia is not there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the wrong benchmark set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. So what do you think of the error on Vaibhav's pr.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
show the error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this : commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That commit doesn't add openmodelica at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That has what I have been saying chris but the error points out to openmodelica.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the latest error https://buildkite.com/julialang/scimlbenchmarks-dot-jl/builds/3412#0197d4d8-ee5a-4269-ab8f-1fae086e1c49 and it does not point to openmodelica. Nor is openmodelica installed at all. Nor should it be: these benchmarks are not of DAEs, there is no modelica here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, will look into it and try again.