dual-key-remap: Add manifest for v0.11#17461
dual-key-remap: Add manifest for v0.11#17461OmiChrome wants to merge 4 commits intoScoopInstaller:masterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdded a new Scoop package manifest for the Windows Changes
Sequence Diagram(s)sequenceDiagram
participant UserInstaller as "Scoop/Installer (PowerShell)"
participant FileSystem as "File System"
participant TaskScheduler as "Windows Task Scheduler"
participant Process as "dual-key-remap.exe (Process)"
UserInstaller->>FileSystem: write install-dual-key-startup.ps1
UserInstaller->>TaskScheduler: register 'DualKeyRemap' scheduled task (logon, highest, interactive)
TaskScheduler-->>UserInstaller: registration output / status
UserInstaller->>FileSystem: verify dual-key-remap.exe exists
alt exe missing
UserInstaller->>UserInstaller: error out
else exe present
UserInstaller->>Process: check if running
alt not running
UserInstaller->>Process: attempt elevated start
Process-->>UserInstaller: start status
else running
Process-->>UserInstaller: already running
end
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All changes look good. Wait for review from human collaborators. dual-key-remap
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@bucket/dual-key-remap.json`:
- Around line 21-23: The scheduled task currently dereferences the Scoop symlink
by using (Get-Item "$PSScriptRoot").Target which embeds a concrete version path
into $scoopDir and breaks after updates; change the logic in the startup script
around $scoopDir/$PSScriptRoot/$exe to prefer the stable 'current' symlink path
(e.g., set $scoopDir to Join-Path $PSScriptRoot 'current' if that path exists
and is a symlink), and only fall back to $PSScriptRoot when 'current' is absent,
ensuring the fallback handles empty/null and non-existent paths so the task
always points at the moving 'current' link instead of a pinned versioned folder.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c6496055-ce6f-4d2c-a5b1-86f39d8ff2bc
📒 Files selected for processing (1)
bucket/dual-key-remap.json
|
Good catch @coderabbitai — you're absolutely right. I originally used (Get-Item "").Target thinking I needed to resolve the symlink at install time, but that's the wrong direction: it pins the task to the concrete versioned folder (e.g. |
|
Tip For best results, initiate chat on the files or code changes.
The fix is to reference the $exePath = "$env:SCOOP\apps\dual-key-remap\current\dual-key-remap.exe"Since Scoop keeps |
|
Tip For best results, initiate chat on the files or code changes.
✏️ Learnings added
🧠 Learnings usedIf you found this review helpful, would you consider giving us a shout-out on X? Thank you for using CodeRabbit! |
|
@z-Fng everything is clear |
New Manifest: dual-key-remap v0.11
Homepage: https://github.com/ililim/dual-key-remap
License: GPL-2.0-only
Description: Remap any key to any other two keys on Windows. Remap CapsLock to both Ctrl and Escape!
Features
checkver/autoupdatefor automatic version tracking via GitHub releasespersistforconfig.txtso user config survives updatesinstall-dual-key-startup) that registers a Windows Scheduled Task at Highest RunLevel, pointing through the Scoopcurrentsymlink so it never breaks on updateChecklist
checkver/autoupdateconfiguredSummary by CodeRabbit