Skip to content

Commit f228375

Browse files
committed
Chore: Code refactoring
1 parent c66754e commit f228375

File tree

2 files changed

+15
-39
lines changed

2 files changed

+15
-39
lines changed

src/main/java/net/seesharpsoft/intellij/plugins/csv/components/CsvEscapeCharacter.java

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import com.intellij.util.xmlb.Converter;
44
import com.intellij.xml.util.XmlStringUtil;
55
import org.jetbrains.annotations.NotNull;
6+
import org.jetbrains.annotations.Nullable;
67

78
import java.util.regex.Pattern;
89

@@ -13,20 +14,13 @@ public class CsvEscapeCharacter extends CsvCustomizableElement {
1314
public static CsvEscapeCharacter BACKSLASH = new CsvEscapeCharacter("\\", "Backslash (\\)", "\\\\", "BACKSLASH");
1415

1516
public static CsvEscapeCharacter[] values() {
16-
return new CsvEscapeCharacter[]{QUOTE, BACKSLASH};
17+
return new CsvEscapeCharacter[]{ QUOTE, BACKSLASH };
1718
}
1819

19-
public static CsvEscapeCharacter getDefaultEscapeCharacter(String character) {
20-
if (character != null) {
21-
switch (character) {
22-
case "QUOTE":
23-
case "\"":
24-
return QUOTE;
25-
case "BACKSLASH":
26-
case "\\":
27-
return BACKSLASH;
28-
default:
29-
break;
20+
private static @Nullable CsvEscapeCharacter getDefaultEscapeCharacter(@NotNull String character) {
21+
for (CsvEscapeCharacter defaultEC : values()) {
22+
if (defaultEC.getCharacter().equals(character) || defaultEC.getName().equals(character)) {
23+
return defaultEC;
3024
}
3125
}
3226
return null;

src/main/java/net/seesharpsoft/intellij/plugins/csv/components/CsvValueSeparator.java

Lines changed: 9 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import com.intellij.util.xmlb.Converter;
44
import com.intellij.xml.util.XmlStringUtil;
55
import org.jetbrains.annotations.NotNull;
6+
import org.jetbrains.annotations.Nullable;
67

78
import java.util.regex.Pattern;
89

@@ -16,29 +17,14 @@ public class CsvValueSeparator extends CsvCustomizableElement {
1617
public static final CsvValueSeparator COLON = new CsvValueSeparator(":", "Colon (:)", "COLON");
1718
public static final CsvValueSeparator RS = new CsvValueSeparator("\u001E", "Record Separator ([RS])", "RS", true);
1819

19-
public static CsvValueSeparator getDefaultValueSeparator(String character) {
20-
if (character != null) {
21-
switch (character) {
22-
case "COMMA":
23-
case ",":
24-
return COMMA;
25-
case "SEMICOLON":
26-
case ";":
27-
return SEMICOLON;
28-
case "PIPE":
29-
case "|":
30-
return PIPE;
31-
case "TAB":
32-
case "\t":
33-
return TAB;
34-
case "COLON":
35-
case ":":
36-
return COLON;
37-
case "RS":
38-
case "\u001E":
39-
return RS;
40-
default:
41-
break;
20+
public static CsvValueSeparator @NotNull [] values() {
21+
return new CsvValueSeparator[]{ COMMA, SEMICOLON, PIPE, TAB, COLON, RS };
22+
}
23+
24+
private static @Nullable CsvValueSeparator getDefaultValueSeparator(@NotNull String character) {
25+
for (CsvValueSeparator defaultVS : values()) {
26+
if (defaultVS.getCharacter().equals(character) || defaultVS.getName().equals(character)) {
27+
return defaultVS;
4228
}
4329
}
4430
return null;
@@ -52,10 +38,6 @@ public static CsvValueSeparator create(String character) {
5238
return defaultValueSeparator == null ? new CsvValueSeparator(character) : defaultValueSeparator;
5339
}
5440

55-
public static CsvValueSeparator[] values() {
56-
return new CsvValueSeparator[]{COMMA, SEMICOLON, PIPE, TAB, COLON, RS};
57-
}
58-
5941
public static class CsvValueSeparatorConverter extends Converter<CsvValueSeparator> {
6042
public CsvValueSeparator fromString(@NotNull String value) {
6143
return CsvValueSeparator.create(XmlStringUtil.unescapeIllegalXmlChars(value));

0 commit comments

Comments
 (0)