[Refactor] Enable auto-detection of screenshot generator renderer #796
+16
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #795. Changes made:
is_screenshot_generator
property to baseRenderer
class. ReturnsFalse
by defaultis_screenshot_generator
property toScreenshotRenderer
class. ReturnsTrue
to identify it as the screenshot generatoris_screenshot_renderer
parameter fromOpeningSplashView
since it's no longer neededOpeningSplashScreen
to useself.renderer.is_screenshot_generator
instead of the passed parameteris_screenshot_renderer
parameter from the test configurationsThis pull request is categorized as a:
Checklist
pytest
and made sure all unit tests pass before sumbitting the PRIf you modified or added functionality/workflow, did you add new unit tests?
I have tested this PR on the following platforms/os:
Note: Keep your changes limited in scope; if you uncover other issues or improvements along the way, ideally submit those as a separate PR. The more complicated the PR the harder to review, test, and merge.