Skip to content

Conversation

alvroble
Copy link
Contributor

Description

Fixes #795. Changes made:

  • Added is_screenshot_generator property to base Renderer class. Returns False by default
  • Added is_screenshot_generator property to ScreenshotRenderer class. Returns True to identify it as the screenshot generator
  • Removed the is_screenshot_renderer parameter from OpeningSplashView since it's no longer needed
  • Modified OpeningSplashScreen to use self.renderer.is_screenshot_generator instead of the passed parameter
  • Updated screenshot generator tests. Removed the is_screenshot_renderer parameter from the test configurations

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Documentation
  • Other

Checklist

  • I’ve run pytest and made sure all unit tests pass before sumbitting the PR

If you modified or added functionality/workflow, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms/os:

Note: Keep your changes limited in scope; if you uncover other issues or improvements along the way, ideally submit those as a separate PR. The more complicated the PR the harder to review, test, and merge.

@alvroble alvroble changed the title [Refactor] Enable auto-detection of screenshot generation renderer [Refactor] Enable auto-detection of screenshot generator renderer Jul 29, 2025
Copy link
Contributor

@Chaitanya-Keyal Chaitanya-Keyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

Copy link
Contributor

@Chaitanya-Keyal Chaitanya-Keyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest rebasing with dev and modifying RestartView to also use renderer.is_screenshot_generator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-detect when running in the screenshot generator
2 participants