[Refactor] use Seed
instead of seed_num
#810
Open
+234
−266
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the seed views to pass the selected
Seed
object directly to the next view instead of usingseed_num
.Previously, almost every view would immediately dereference
seed_num
to fetch theSeed
object fromSeedStorage
, resulting in redundant lookups. Passing theSeed
object itself removes that redundancy and provides a more robust reference to the selected seed, avoiding potential fragility in the future.The motivation for this change came up while I was working on #785. In that context, it became clear that relying on
seed_num
is brittle, since it’s only the index of a mutable list. See my comment for details.Benefits:
This pull request is categorized as a:
Checklist
pytest
and made sure all unit tests pass before submitting the PRIf you modified or added functionality/workflow, did you add new unit tests?
I have tested this PR on the following platforms/os: