Skip to content

Commit 2d4be06

Browse files
authored
Docker: Use GreedySlotSelector in Hub and Standalone (#2915)
1 parent a177525 commit 2d4be06

File tree

6 files changed

+8
-3
lines changed

6 files changed

+8
-3
lines changed

Base/Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,7 @@ ENV SE_BIND_HOST="false" \
203203
SE_SERVER_PROTOCOL="http" \
204204
# Boolean value, maps "--reject-unsupported-caps"
205205
SE_REJECT_UNSUPPORTED_CAPS="false" \
206+
SE_DISTRIBUTOR_SLOT_SELECTOR="org.openqa.selenium.grid.distributor.selector.GreedySlotSelector" \
206207
SE_OTEL_JAVA_GLOBAL_AUTOCONFIGURE_ENABLED="true" \
207208
SE_OTEL_TRACES_EXPORTER="otlp" \
208209
SE_SUPERVISORD_LOG_LEVEL="info" \

ENV_VARIABLES.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,4 +154,4 @@
154154
| SE_VIDEO_MAXRATE | | | |
155155
| SE_NODE_DELETE_SESSION_ON_UI | true | Enable capability to support deleting session on Grid UI | --delete-session-on-ui |
156156
| SE_UPDATE_CHROME_COMPONENTS | | Applicable for node-chrome, standalone-chrome (arch linux/amd64). Update the latest version of Chrome and ChromeDriver at the beginning of the container startup. Read more: [#2872](https://github.com/SeleniumHQ/docker-selenium/pull/2872) | |
157-
| SE_DISTRIBUTOR_SLOT_SELECTOR | | Full class name of non-default slot selector. This is used to select a slot in a Node once the Node has been matched. | --slot-selector |
157+
| SE_DISTRIBUTOR_SLOT_SELECTOR | org.openqa.selenium.grid.distributor.selector.GreedySlotSelector | Full class name of non-default slot selector. This is used to select a slot in a Node once the Node has been matched. Switch to default, use class name `org.openqa.selenium.grid.distributor.selector.DefaultSlotSelector` | --slot-selector |

charts/selenium-grid/CONFIGURATION.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -411,6 +411,7 @@ A Helm chart for creating a Selenium Grid Server in Kubernetes
411411
| autoscaling.patchObjectFinalizers.imagePullSecret | string | `""` | Custom pull secret for container in patch job |
412412
| autoscaling.patchObjectFinalizers.resources | object | `{"limits":{"cpu":"200m","memory":"500Mi"},"requests":{"cpu":"100m","memory":"200Mi"}}` | Define resources for container in patch job |
413413
| autoscaling.patchObjectFinalizers.nodeSelector | object | `{}` | Node selector for the patch job |
414+
| autoscaling.patchObjectFinalizers.tolerations | list | `[]` | Tolerations for the patch job |
414415
| autoscaling.scaledOptions | object | `{"maxReplicaCount":24,"minReplicaCount":0,"pollingInterval":20}` | Options for KEDA scaled resources (keep only common options used for both ScaledJob and ScaledObject) |
415416
| autoscaling.scaledOptions.minReplicaCount | int | `0` | Minimum number of replicas |
416417
| autoscaling.scaledOptions.maxReplicaCount | int | `24` | Maximum number of replicas |

charts/selenium-grid/values.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1080,6 +1080,8 @@ autoscaling:
10801080
memory: 500Mi
10811081
# -- Node selector for the patch job
10821082
nodeSelector: {}
1083+
# -- Tolerations for the patch job
1084+
tolerations: []
10831085
# -- Options for KEDA scaled resources (keep only common options used for both ScaledJob and ScaledObject)
10841086
scaledOptions:
10851087
# Don't define `triggers` config here, it will apply the same to all node types. Instead, define it under `scaledOptions` of different node type

scripts/generate_list_env_vars/description.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -479,5 +479,6 @@
479479
cli: ''
480480
- name: SE_DISTRIBUTOR_SLOT_SELECTOR
481481
description: Full class name of non-default slot selector. This is used to select
482-
a slot in a Node once the Node has been matched.
482+
a slot in a Node once the Node has been matched. Switch to default, use class
483+
name `org.openqa.selenium.grid.distributor.selector.DefaultSlotSelector`
483484
cli: --slot-selector

scripts/generate_list_env_vars/value.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
- name: SE_DISTRIBUTOR_PORT
2020
default: '5553'
2121
- name: SE_DISTRIBUTOR_SLOT_SELECTOR
22-
default: ''
22+
default: org.openqa.selenium.grid.distributor.selector.GreedySlotSelector
2323
- name: SE_DRAIN_AFTER_SESSION_COUNT
2424
default: '0'
2525
- name: SE_ENABLE_BROWSER_LEFTOVERS_CLEANUP

0 commit comments

Comments
 (0)