Skip to content

Conversation

@VietND96
Copy link
Member

@VietND96 VietND96 commented Oct 19, 2025

User description

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Enhancement


Description

  • Update Selenium Grid to version 4.37.0

  • Bump OpenTelemetry, gRPC, and Netty dependencies

  • Update KEDA to version 2.18.0

  • Add Firefox 143 and 144 browser versions

  • Disable KEDA patch object finalizers by default

  • Update Chrome and Edge versions in test matrix


Diagram Walkthrough

flowchart LR
  A["Selenium Grid 4.36.0"] -- "upgrade to" --> B["Selenium Grid 4.37.0"]
  C["OpenTelemetry 1.54.1"] -- "bump to" --> D["OpenTelemetry 1.55.0"]
  E["gRPC 1.75.0"] -- "bump to" --> F["gRPC 1.76.0"]
  G["Netty 4.2.6"] -- "bump to" --> H["Netty 4.2.7"]
  I["KEDA 2.17.2"] -- "upgrade to" --> J["KEDA 2.18.0"]
  K["Firefox versions"] -- "add" --> L["Firefox 143, 144"]
  B --> M["Updated Configuration"]
  D --> M
  F --> M
  H --> M
  J --> M
  L --> M
Loading

File Walkthrough

Relevant files
Configuration changes
4 files
Makefile
Update Selenium Grid and dependency versions                         
+9/-9     
release-firefox-versions.yml
Add Firefox 143 to default build versions                               
+1/-1     
values.yaml
Disable KEDA patch finalizers and remove commented config
+1/-15   
multiple-nodes-platform-version.yaml
Add Firefox 143 node configuration                                             
+5/-0     
Dependencies
1 files
Dockerfile
Bump OpenTelemetry, gRPC, Netty versions                                 
+3/-3     
Documentation
1 files
CONFIGURATION.md
Update KEDA patch finalizers default value documentation 
+1/-1     
Tests
3 files
browser-matrix.yml
Add Firefox 144 and update Chrome/Edge versions                   
+5/-2     
firefox-matrix.yml
Add Firefox 144 to test matrix                                                     
+2/-0     
selenium-matrix.yml
Add Selenium 4.37.0 to test matrix                                             
+6/-0     

@qodo-merge-pro
Copy link
Contributor

qodo-merge-pro bot commented Oct 19, 2025

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
- [ ] Create ticket/issue <!-- /create_ticket --create_ticket=true -->

</details></td></tr>
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
No custom compliance provided

Follow the guide to enable custom compliance check.

  • Update
Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-merge-pro
Copy link
Contributor

qodo-merge-pro bot commented Oct 19, 2025

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Learned
best practice
Quote ambiguous YAML strings

Quote all string values, including lists encoded as comma-separated strings, to
avoid implicit numeric or unparsed list interpretations.

tests/build-backward-compatible/browser-matrix.yml [3-5]

-'144':
-  FIREFOX_VERSION: '144.0'
-  FIREFOX_PLATFORMS: linux/amd64,linux/arm64
+"144":
+  FIREFOX_VERSION: "144.0"
+  FIREFOX_PLATFORMS: "linux/amd64,linux/arm64"
  • Apply / Chat
Suggestion importance[1-10]: 6

__

Why:
Relevant best practice - Harden YAML by quoting string values that look like numbers or contain dots to prevent unintended type coercion across parsers.

Low
Use consistent double quotes

Use double quotes consistently for string literals to avoid templating or
parsing surprises and keep style uniform with the rest of the file.

charts/selenium-grid/multiple-nodes-platform-version.yaml [242-246]

-- nameOverride: '{{ $.Release.Name }}-node-firefox-143'
-  imageTag: '143.0-20251001'
+- nameOverride: "{{ $.Release.Name }}-node-firefox-143"
+  imageTag: "143.0-20251001"
   hpa:
-    platformName: 'Linux'
-    browserVersion: '143.0'
+    platformName: "Linux"
+    browserVersion: "143.0"
  • Apply / Chat
Suggestion importance[1-10]: 5

__

Why:
Relevant best practice - Harden YAML templating by keeping consistent, explicit quoting for values that may be parsed ambiguously (strings that look like numbers or contain dots).

Low
General
Use specific patch version for Firefox

For consistency with other browser versions in the test matrix, update the
FIREFOX_VERSION for '144' from the major version '144.0' to a specific patch
version (e.g., '144.0.2').

tests/build-backward-compatible/browser-matrix.yml [1-16]

 matrix:
   browser:
     '144':
-      FIREFOX_VERSION: '144.0'
+      FIREFOX_VERSION: '144.0.2'
       FIREFOX_PLATFORMS: linux/amd64,linux/arm64
     '143':
       FIREFOX_VERSION: 143.0.4
       FIREFOX_PLATFORMS: linux/amd64,linux/arm64
     '142':
       FIREFOX_VERSION: 142.0.1
       FIREFOX_PLATFORMS: linux/amd64,linux/arm64
     '141':
       EDGE_VERSION: microsoft-edge-stable=141.0.3537.85-1
       CHROME_VERSION: google-chrome-stable=141.0.7390.107-1
       FIREFOX_VERSION: 141.0.3
       FIREFOX_PLATFORMS: linux/amd64,linux/arm64
  • Apply / Chat
Suggestion importance[1-10]: 5

__

Why: The suggestion correctly identifies an inconsistency in the Firefox version specification and recommends using a specific patch version, which is a good practice for test stability and reproducibility.

Low
  • Update

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
@VietND96 VietND96 force-pushed the selenium-grid-4.37.0 branch from 9eb0080 to 0bc6478 Compare October 19, 2025 07:49
@VietND96 VietND96 enabled auto-merge (squash) October 19, 2025 08:46
@VietND96 VietND96 disabled auto-merge October 19, 2025 08:46
@VietND96 VietND96 merged commit 4a17896 into trunk Oct 19, 2025
29 checks passed
@VietND96 VietND96 deleted the selenium-grid-4.37.0 branch October 19, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants