-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
K8s: Expose config session request timeout in Helm chart values #3006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
||||||||||||||||||||||||
PR Code Suggestions ✨No code suggestions found for the PR. |
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist
PR Type
Enhancement
Description
Expose
sessionRequestTimeoutconfiguration in Helm chart valuesAllow global and component-level override of session request timeout
Add
SE_SESSION_REQUEST_TIMEOUTenvironment variable to Hub and Session QueueUpdate test configuration to use new values parameter
Diagram Walkthrough
File Walkthrough
CONFIGURATION.md
Document session request timeout parameterscharts/selenium-grid/CONFIGURATION.md
global.seleniumGrid.sessionRequestTimeoutparameter with 300 second default
components.sessionQueue.sessionRequestTimeoutoverride parameter
hub.sessionRequestTimeoutoverride parameterhub-deployment.yaml
Add session timeout to Hub deploymentcharts/selenium-grid/templates/hub-deployment.yaml
SE_SESSION_REQUEST_TIMEOUTenvironment variable to Hub deploymentglobal value
session-queue-deployment.yaml
Add session timeout to Session Queue deploymentcharts/selenium-grid/templates/session-queue-deployment.yaml
SE_SESSION_REQUEST_TIMEOUTenvironment variable to Session Queuedeployment
global value
values.yaml
Add session timeout configuration parameterscharts/selenium-grid/values.yaml
global.seleniumGrid.sessionRequestTimeoutwith default value of300 seconds
components.sessionQueue.sessionRequestTimeoutoverride parameterhub.sessionRequestTimeoutoverride parameterbase-auth-ingress-values.yaml
Update test configuration to use new parametertests/charts/ci/base-auth-ingress-values.yaml
sessionRequestTimeout: 800to global seleniumGrid configurationSE_SESSION_REQUEST_TIMEOUTenvironment variable fromhub extraEnvironmentVariables
environment variable