Skip to content

Commit 093fd7f

Browse files
AB-xdevdiemol
andauthored
[java] Made JsonToWebElementConverter methods/fields protected (#15885)
Made ``JsonToWebElementConverter`` methods protected so that the class can be properly extended Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
1 parent 21b07d5 commit 093fd7f

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

java/src/org/openqa/selenium/remote/JsonToWebElementConverter.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
*/
3131
public class JsonToWebElementConverter implements Function<Object, Object> {
3232

33-
private final RemoteWebDriver driver;
33+
protected final RemoteWebDriver driver;
3434

3535
public JsonToWebElementConverter(RemoteWebDriver driver) {
3636
this.driver = driver;
@@ -81,15 +81,15 @@ protected RemoteWebElement newRemoteWebElement() {
8181
return setOwner(new RemoteWebElement());
8282
}
8383

84-
private RemoteWebElement setOwner(RemoteWebElement element) {
84+
protected RemoteWebElement setOwner(RemoteWebElement element) {
8585
if (driver != null) {
8686
element.setParent(driver);
8787
element.setFileDetector(driver.getFileDetector());
8888
}
8989
return element;
9090
}
9191

92-
private String getElementKey(Map<?, ?> resultAsMap) {
92+
protected String getElementKey(Map<?, ?> resultAsMap) {
9393
for (Dialect d : Dialect.values()) {
9494
String elementKeyForDialect = d.getEncodedElementKey();
9595
if (resultAsMap.containsKey(elementKeyForDialect)) {
@@ -99,7 +99,7 @@ private String getElementKey(Map<?, ?> resultAsMap) {
9999
return null;
100100
}
101101

102-
private String getShadowRootKey(Map<?, ?> resultAsMap) {
102+
protected String getShadowRootKey(Map<?, ?> resultAsMap) {
103103
for (Dialect d : Dialect.values()) {
104104
String shadowRootElementKey = d.getShadowRootElementKey();
105105
if (resultAsMap.containsKey(shadowRootElementKey)) {

0 commit comments

Comments
 (0)