[java] Feat 14291/jspecify nullable annotation edge driver service (#15972)

* Add Nullable annotations to Builder class fields in EdgeDriverService

* Add Nullable annotations to parameters in EdgeDriverService and DriverService constructors

* Refactor EdgeDriverService class documentation and structure

* Add dependency on jspecify for EdgeDriver

---------

Co-authored-by: Diego Molina <diemol@users.noreply.github.com>

Author: iampopovich

java/src/org/openqa/selenium/edge/BUILD.bazel

@@ -21,5 +21,6 @@ java_export(
         "//java/src/org/openqa/selenium/chromium",
         "//java/src/org/openqa/selenium/manager",
         "//java/src/org/openqa/selenium/remote",
+        "@maven//:org_jspecify_jspecify",
     ],
 )

java/src/org/openqa/selenium/edge/EdgeDriverService.java

@@ -29,6 +29,7 @@
 import java.util.List;
 import java.util.Locale;
 import java.util.Map;
+import org.jspecify.annotations.Nullable;
 import org.openqa.selenium.Capabilities;
 import org.openqa.selenium.WebDriverException;
 import org.openqa.selenium.chromium.ChromiumDriverLogLevel;
@@ -96,11 +97,11 @@ public class EdgeDriverService extends DriverService {
    * @throws IOException If an I/O error occurs.
    */
   public EdgeDriverService(
-      File executable,
+      @Nullable File executable,
       int port,
-      Duration timeout,
-      List<String> args,
-      Map<String, String> environment)
+      @Nullable Duration timeout,
+      @Nullable List<String> args,
+      @Nullable Map<String, String> environment)
       throws IOException {
     super(executable, port, timeout, List.copyOf(args), Map.copyOf(environment));
   }
@@ -139,13 +140,13 @@ public static EdgeDriverService createDefaultService() {
   @AutoService(DriverService.Builder.class)
   public static class Builder extends DriverService.Builder<EdgeDriverService, Builder> {
 
-    private Boolean disableBuildCheck;
-    private Boolean readableTimestamp;
-    private Boolean appendLog;
-    private Boolean verbose;
-    private Boolean silent;
-    private String allowedListIps;
-    private ChromiumDriverLogLevel logLevel;
+    @Nullable private Boolean disableBuildCheck;
+    @Nullable private Boolean readableTimestamp;
+    @Nullable private Boolean appendLog;
+    @Nullable private Boolean verbose;
+    @Nullable private Boolean silent;
+    @Nullable private String allowedListIps;
+    @Nullable private ChromiumDriverLogLevel logLevel;
 
     @Override
     public int score(Capabilities capabilities) {
@@ -196,7 +197,7 @@ public Builder withBuildCheckDisabled(boolean noBuildCheck) {
      * @param logLevel {@link ChromiumDriverLogLevel} for desired log level output.
      * @return A self reference.
      */
-    public Builder withLoglevel(ChromiumDriverLogLevel logLevel) {
+    public Builder withLoglevel(@Nullable ChromiumDriverLogLevel logLevel) {
       this.logLevel = logLevel;
       this.silent = false;
       this.verbose = false;
@@ -238,7 +239,7 @@ public Builder withVerbose(boolean verbose) {
      * @param allowedListIps Comma-separated list of remote IPv4 addresses.
      * @return A self reference.
      */
-    public Builder withAllowedListIps(String allowedListIps) {
+    public Builder withAllowedListIps(@Nullable String allowedListIps) {
       this.allowedListIps = allowedListIps;
       return this;
     }
@@ -249,7 +250,7 @@ public Builder withAllowedListIps(String allowedListIps) {
      * @param readableTimestamp Whether the timestamp of the log is readable.
      * @return A self reference.
      */
-    public Builder withReadableTimestamp(Boolean readableTimestamp) {
+    public Builder withReadableTimestamp(@Nullable Boolean readableTimestamp) {
       this.readableTimestamp = readableTimestamp;
       return this;
     }
@@ -321,7 +322,11 @@ protected List<String> createArgs() {
 
     @Override
     protected EdgeDriverService createDriverService(
-        File exe, int port, Duration timeout, List<String> args, Map<String, String> environment) {
+        @Nullable File exe,
+        int port,
+        @Nullable Duration timeout,
+        @Nullable List<String> args,
+        @Nullable Map<String, String> environment) {
       try {
         return new EdgeDriverService(exe, port, timeout, args, environment);
       } catch (IOException e) {

java/src/org/openqa/selenium/remote/service/DriverService.java

@@ -106,11 +106,11 @@ public class DriverService implements Closeable {
    * @throws IOException If an I/O error occurs.
    */
   protected DriverService(
-      File executable,
+      @Nullable File executable,
       int port,
-      Duration timeout,
-      List<String> args,
-      Map<String, String> environment)
+      @Nullable Duration timeout,
+      @Nullable List<String> args,
+      @Nullable Map<String, String> environment)
       throws IOException {
     if (executable != null) {
       this.executable = executable.getCanonicalPath();