-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
[rb] Upgrade to Ruby 3.2 #15714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
[rb] Upgrade to Ruby 3.2 #15714
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
CI Feedback 🧐(Feedback updated until commit 0ccbc01)A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
5e23fb6
to
635accc
Compare
ea1b407
to
b42ecb2
Compare
- CRuby 3.1 is EOL - JRuby 10 is the latest - TruffleRuby 24.2 is the latest
Hmm @cgoldberg any idea why the python remote tests don't like Java 21? |
I have no idea. What's failing? I use Java 17 on my local, but I can try 21. Edit: ok.. I see the errors. I'll look into it this afternoon. |
I ran the remote tests in trunk with Java 21 (not using bazel, not using this PR branch), and everything ran fine. In the CI logs for this PR, there are a ton of errors that occur when calling
I don't know what they mean. |
I would guess this change is causing it: |
@cgoldberg I think it's caused by my changes, let me revert and see if it helps. As I said, I have no idea what I do in Java code. |
java.lang.ClassCastException: class jdk.internal.net.http.HttpClientFacade cannot be cast to class java.lang.AutoCloseable (jdk.internal.net.http.HttpClientFacade is in module java.net.http of loader 'platform'; java.lang.AutoCloseable is in module java.base of loader 'bootstrap'
@cgoldberg @titusfortner All green now. |
User description
PR Type
Enhancement
Description
Upgrade minimum supported Ruby version to 3.2
.ruby-version
, gemspecs, and documentationUpdate CI workflows to use latest Ruby, JRuby, TruffleRuby
Update Bazel and Ruby dependencies
rules_ruby
and various Ruby gem versions/checksumsChanges walkthrough 📝
2 files
Require Ruby >= 3.2 in gemspec
Require Ruby >= 3.2 in gemspec
5 files
Update JRuby version in CI workflow to 10.0.0.0
Update Ruby, JRuby, TruffleRuby versions in CI matrix
Use Ruby 3.2 in pre-release workflow
Set RuboCop TargetRubyVersion to 3.2
Set Ruby version to 3.2.8
1 files
Update rules_ruby and Ruby gem dependencies
1 files
Update documentation for Ruby >= 3.2 support