Skip to content

[dotnet] Remove unnecessary stylecop files #15824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2025

Conversation

nvborisenko
Copy link
Member

@nvborisenko nvborisenko commented May 29, 2025

User description

🔗 Related Issues

💥 What does this PR do?

In codebase we see some files related to C# code analysis. But these files are not used. So just remove it.

🔧 Implementation Notes

💡 Additional Considerations

Currently there is no tool to track code style. We have to introduce it via .editorconfig. I already placed a placeholder here: https://github.com/SeleniumHQ/selenium/blob/trunk/dotnet/.editorconfig

In future I think we will take what .NET itself uses and make big restyling entire codebase.

🔄 Types of changes

  • Cleanup (formatting, renaming)
  • Bug fix (backwards compatible)
  • New feature (non-breaking change which adds functionality and tests!)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR Type

Other


Description

  • Remove unused StyleCop files from .NET projects

  • Clean up project files by eliminating references to StyleCop

  • Prepare codebase for future style tooling via .editorconfig


Changes walkthrough 📝

Relevant files
Configuration changes
9 files
WebDriver.Support.csproj
Remove StyleCop references from support project                   
+0/-11   
WebDriver.Chrome.Tests.csproj
Remove StyleCop references from Chrome tests project         
+0/-7     
WebDriver.Safari.Tests.csproj
Remove StyleCop references from Safari tests project         
+0/-6     
WebDriver.IE.Tests.csproj
Remove StyleCop references from IE tests project                 
+0/-6     
WebDriver.csproj
Remove StyleCop references from main WebDriver project     
+0/-5     
WebDriver.Support.Tests.csproj
Remove StyleCop references from support tests project       
+0/-5     
WebDriver.Remote.Tests.csproj
Remove StyleCop references from remote tests project         
+0/-4     
WebDriver.Firefox.Tests.csproj
Remove StyleCop references from Firefox tests project       
+0/-6     
WebDriver.Common.Tests.csproj
Remove StyleCop references from common tests project         
+0/-4     
Additional files
10 files
Settings.StyleCop +0/-19   
WebDriver.Support.ruleset +0/-8     
Settings.StyleCop +0/-44   
WebDriver.ruleset +0/-13   
Settings.StyleCop +0/-759 
Settings.StyleCop +0/-759 
Settings.StyleCop +0/-759 
Settings.StyleCop +0/-759 
Settings.StyleCop +0/-759 
Settings.StyleCop +0/-759 

Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link
    Contributor

    qodo-merge-pro bot commented May 29, 2025

    PR Reviewer Guide 🔍

    (Review updated until commit f084cc8)

    Here are some key observations to aid the review process:

    🎫 Ticket compliance analysis ❌

    1234 - Not compliant

    Non-compliant requirements:

    • Fix issue where Selenium 2.48 doesn't trigger JavaScript in link's href on click()
    • Ensure JavaScript in href attributes works properly when clicked
    • Fix regression from version 2.47.1 to 2.48.0/2.48.2
    • Fix specifically for Firefox 42.0

    5678 - Not compliant

    Non-compliant requirements:

    • Fix "Error: ConnectFailure (Connection refused)" when instantiating ChromeDriver
    • Address issue where only the first ChromeDriver instance works correctly
    • Fix for Chrome 65.0.3325.181 with ChromeDriver version 2.35
    • Fix for Ubuntu 16.04.4 with Linux 4.10.0

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    qodo-merge-pro bot commented May 29, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @nvborisenko
    Copy link
    Member Author

    @selenium-ci selenium-ci added C-dotnet .NET Bindings B-support Issue or PR related to support classes labels May 29, 2025
    @selenium-ci
    Copy link
    Member

    Thank you, @nvborisenko for this code suggestion.

    The support packages contain example code that many users find helpful, but they do not necessarily represent
    the best practices for using Selenium, and the Selenium team is not currently merging changes to them.

    We actively encourage people to add the wrapper and helper code that makes sense for them to their own frameworks.
    If you have any questions, please contact us

    @nvborisenko nvborisenko reopened this May 29, 2025
    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @nvborisenko nvborisenko merged commit 962906d into SeleniumHQ:trunk May 29, 2025
    23 checks passed
    @nvborisenko nvborisenko deleted the stylecope branch June 1, 2025 22:37
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    B-support Issue or PR related to support classes C-dotnet .NET Bindings Review effort 1/5
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants