Skip to content

[rust] Update which from 7.0.3 to 8.0.0 #15965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

musicinmybrain
Copy link

@musicinmybrain musicinmybrain commented Jun 26, 2025

User description

🔗 Related Issues

N/A

💥 What does this PR do?

Updates the Rust dependency on the which crate from 7.0.3 to 8.0.0, without code changes.

🔧 Implementation Notes

N/A

💡 Additional Considerations

See https://github.com/harryfei/which-rs/releases/tag/8.0.0 for release notes.

I tested this with cargo test. I found that grid_latest_test and grid_version_test failed both before and after this PR in my environment, and all other tests passed.

🔄 Types of changes

N/A, dependency update.


PR Type

Other


Description

  • Update Rust which crate dependency from 7.0.3 to 8.0.0

Changes walkthrough 📝

Relevant files
Dependencies
Cargo.toml
Update which crate dependency version                                       

rust/Cargo.toml

  • Updated which crate version from 7.0.3 to 8.0.0
+1/-1     

Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @CLAassistant
    Copy link

    CLAassistant commented Jun 26, 2025

    CLA assistant check
    All committers have signed the CLA.

    @selenium-ci selenium-ci added C-rust Rust code is mostly Selenium Manager B-manager Selenium Manager labels Jun 26, 2025
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🎫 Ticket compliance analysis ❌

    1234 - Not compliant

    Non-compliant requirements:

    • Fix JavaScript execution in link's href attribute when using click() method
    • Ensure compatibility with Firefox 42.0
    • Restore functionality that worked in version 2.47.1 but broke in 2.48.0/2.48.2

    5678 - Not compliant

    Non-compliant requirements:

    • Fix ChromeDriver connection failure errors on Ubuntu 16.04.4
    • Resolve "ConnectFailure (Connection refused)" errors for subsequent ChromeDriver instances
    • Ensure first ChromeDriver instance works without console errors
    • Support Chrome 65.0.3325.181 with ChromeDriver 2.35

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    qodo-merge-pro bot commented Jun 26, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @musicinmybrain musicinmybrain changed the title [rust} Update which from 7.0.3 to 8.0.0 [rust] Update which from 7.0.3 to 8.0.0 Jun 26, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    B-manager Selenium Manager C-rust Rust code is mostly Selenium Manager Review effort 1/5
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants