Skip to content

[deploy site] fixed toml and intro message #2393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2025

Conversation

pallavigitwork
Copy link
Member

@pallavigitwork pallavigitwork commented Jul 28, 2025

User description

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

fixed toml and intro message

Description

fixed toml and intro message

Motivation and Context

fixed toml and intro message

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

Other


Description

  • Fixed Hugo configuration to ignore remote JSON errors

  • Updated ecosystem page introduction text for clarity


Diagram Walkthrough

flowchart LR
  A["Hugo Config"] -- "uncommented" --> B["ignoreErrors setting"]
  C["Ecosystem Page"] -- "rewrote" --> D["Introduction text"]
Loading

File Walkthrough

Relevant files
Configuration changes
hugo.toml
Enable ignoreErrors configuration setting                               

website_and_docs/hugo.toml

  • Uncommented the ignoreErrors configuration line to ignore remote JSON
    errors
+1/-1     
Documentation
_index.html
Improve ecosystem page introduction text                                 

website_and_docs/content/ecosystem/_index.html

  • Rewrote the introduction paragraph for better clarity and flow
  • Improved language to be more welcoming and professional
  • Made the text more concise while maintaining the same meaning
+4/-4     

@pallavigitwork pallavigitwork self-assigned this Jul 28, 2025
Copy link

netlify bot commented Jul 28, 2025

👷 Deploy request for selenium-dev pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 4a869a5

Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

Copy link
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

@pallavigitwork pallavigitwork merged commit 5eb793f into SeleniumHQ:trunk Jul 28, 2025
3 checks passed
@@ -6,7 +6,7 @@ enableRobotsTXT = true

# Will give values to .Lastmod etc.
enableGitInfo = true
#ignoreErrors = ["error-remote-getjson"]
ignoreErrors = ["error-remote-getjson"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if i comment this, the deploy failed with 61 messages of json error logs. enabled it. now it fails with this - Restore or fix website_and_docs/layouts/partials/previous-releases.html to resolve the build failure. If you need help reviewing the contents of this partial, let me know!
this is the summary of the deploy error.
i don't know now what to do to fix this, can you help @diemol , please.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but what is the error you see when this is enabled?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this error message Diego - from deploy action -"Restore or fix website_and_docs/layouts/partials/previous-releases.html to resolve the build failure. If you need help reviewing the contents of this partial, let me know!"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, what is the error you see when ignoreErrors is commented out?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error: error building site: render: failed to render pages: render of "section" failed: "/home/runner/work/seleniumhq.github.io/seleniumhq.github.io/website_and_docs/layouts/downloads/list.html:148:3": execute of template failed: template: downloads/list.html:148:3: executing "main" at <partial "previous-releases.html" .>: error calling partial: "/home/runner/work/seleniumhq.github.io/seleniumhq.github.io/website_and_docs/layouts/partials/previous-releases.html:30:27": execute of template failed: template: partials/previous-releases.html:30:27: executing "partials/previous-releases.html" at <sort $releases "created_at" "desc">: error calling sort: sequence must be provided

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is the error you get when ignoreErrors does not have a # before it.

What is the error you get when ignoreErrors has a # before it? (Commented)

@pallavigitwork
Copy link
Member Author

the error which come when ignorerrors json is commented in toml are listed here - https://github.com/SeleniumHQ/seleniumhq.github.io/actions/runs/16567974653/job/46852569469 .

@diemol
Copy link
Member

diemol commented Jul 28, 2025

ERROR Failed to get JSON resource "https://***@api.github.com/repos/SeleniumHQ/seleniumhq.github.io/contentsexamples/javascript/test/virtual_authenticator/virtualAuthenticator.spec.js?ref=trunk": failed to retrieve remote file: Forbidden, body: "{"message":"API rate limit exceeded for user ID 3331063. If you reach out to GitHub Support for help, please include the request ID E400:1FFCB9:1064EF3:213FC85:68876229 and timestamp 2025-07-28 11:42:33 UTC.","documentation_url":"[https://docs.github.com/rest/overview/rate-limits-for-the-rest-api](https://docs.github.com/rest/overview/rate-limits-for-the-rest-api/)","status":"403"}"

"message":"API rate limit exceeded for user ID 3331063.

That means there is an API rate limit. So we need to wait and try later. There is no reason to ignore these errors. If you ignore them, then other parts of the site won't end up building.

@pallavigitwork
Copy link
Member Author

Ok Diego, thanks. @diemol .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants