-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[deploy site] fixed toml and intro message #2393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
@@ -6,7 +6,7 @@ enableRobotsTXT = true | |||
|
|||
# Will give values to .Lastmod etc. | |||
enableGitInfo = true | |||
#ignoreErrors = ["error-remote-getjson"] | |||
ignoreErrors = ["error-remote-getjson"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if i comment this, the deploy failed with 61 messages of json error logs. enabled it. now it fails with this - Restore or fix website_and_docs/layouts/partials/previous-releases.html to resolve the build failure. If you need help reviewing the contents of this partial, let me know!
this is the summary of the deploy error.
i don't know now what to do to fix this, can you help @diemol , please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, but what is the error you see when this is enabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this error message Diego - from deploy action -"Restore or fix website_and_docs/layouts/partials/previous-releases.html to resolve the build failure. If you need help reviewing the contents of this partial, let me know!"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, what is the error you see when ignoreErrors
is commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error: error building site: render: failed to render pages: render of "section" failed: "/home/runner/work/seleniumhq.github.io/seleniumhq.github.io/website_and_docs/layouts/downloads/list.html:148:3": execute of template failed: template: downloads/list.html:148:3: executing "main" at <partial "previous-releases.html" .>: error calling partial: "/home/runner/work/seleniumhq.github.io/seleniumhq.github.io/website_and_docs/layouts/partials/previous-releases.html:30:27": execute of template failed: template: partials/previous-releases.html:30:27: executing "partials/previous-releases.html" at <sort $releases "created_at" "desc">: error calling sort: sequence must be provided
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is the error you get when ignoreErrors
does not have a #
before it.
What is the error you get when ignoreErrors
has a #
before it? (Commented)
the error which come when ignorerrors json is commented in toml are listed here - https://github.com/SeleniumHQ/seleniumhq.github.io/actions/runs/16567974653/job/46852569469 . |
"message":"API rate limit exceeded for user ID 3331063. That means there is an API rate limit. So we need to wait and try later. There is no reason to ignore these errors. If you ignore them, then other parts of the site won't end up building. |
Ok Diego, thanks. @diemol . |
User description
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
fixed toml and intro message
Description
fixed toml and intro message
Motivation and Context
fixed toml and intro message
Types of changes
Checklist
PR Type
Other
Description
Fixed Hugo configuration to ignore remote JSON errors
Updated ecosystem page introduction text for clarity
Diagram Walkthrough
File Walkthrough
hugo.toml
Enable ignoreErrors configuration setting
website_and_docs/hugo.toml
ignoreErrors
configuration line to ignore remote JSONerrors
_index.html
Improve ecosystem page introduction text
website_and_docs/content/ecosystem/_index.html