Revise the Raspberry Pi Pico sample implementation #10
Conversation
|
Dear @dgoffredo thank you for your pull request and sorry for not getting back earlier to you. Your updates to the Pi Pico sample look good. As we just updated the driver, changing some of the sensor API, it would be nice to update the example to the new version. If you are ok, I could push those changes on top of your pull request. As I do not have a Raspi Pi Pico at hand, would you be able to test the changes afterwards on the Pi Pico? Best, Léonie |
Yes, go ahead. Then I will test the changes and propose any necessary modifications. |
LeonieFierz
force-pushed
the
pico-cleanup
branch
from
1c1f909 to
31850d7
Compare
- Don't read from an uninitiailized boolean variable. - Pull up the SCL and SDA pins used for I2C. - Use sleep_us for higher precision in the HAL. - Add error logging. - Increase precision of reported measurement data. - Remove lengthy sensor self-test. - Remove unused variables and functions. - Address any -Wall -Wextra warnings.
update main.c to changed sensor API, initiaize driver with i2c address, update signature for sensirion_i2c_hal_read/write
LeonieFierz
force-pushed
the
pico-cleanup
branch
from
31850d7 to
d165a99
Compare
|
@dgoffredo |
|
It works! I just tested on my Pico W; works just as the readme says. |
Great, thank you for testing it out! |
I'm using the SCD41 with a Raspberry Pi Pico W, and used this repository's sample implementation as a starting point.
The code in
sample-implementations/RaspberryPi_Pico/has several shortcomings that I aim to correct in this pull request:CMakeLists.txtto have the proper casing.main.c.main.c.This is my first time contributing to this project, so I'm happy to make any changes requested.