Minimalistic dynamic configs #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
tscholak
reviewed
May 20, 2025
Comment on lines
+253
to
+257
| for name in PeftType: | ||
| # We need this because we are using the reserved field name `type`. | ||
| # TODO: Implement proper dynamic typing. | ||
| TransformerPeftConfig.register_subclass(name.value, TransformerPeftConfig) | ||
|
|
There was a problem hiding this comment.
can we use tag instead of type to avoid this workaround?
There was a problem hiding this comment.
We could but I don't think it's worth it. The workaround won't stay long since I already have dynamic implementations in #245. Also keeping type makes the transition easier since we're already keeping that name, eg. so config change or backward compatibility fix is needed.
tscholak
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Description
A simplified version of #245, with only the dynamic config support and its example usage for gpt datasets, i.e. excluding the further usage in cli and transformer sub-configs. I also made it more opt-in by making registries only on request and removing the global config registry.
🔍 Type of change
Select all that apply: