feat(needit): show overdue banner on form + server check via Display BR#190
Open
nilesh-snow-1 wants to merge 3 commits intoServiceNow:masterfrom
Open
feat(needit): show overdue banner on form + server check via Display BR#190nilesh-snow-1 wants to merge 3 commits intoServiceNow:masterfrom
nilesh-snow-1 wants to merge 3 commits intoServiceNow:masterfrom
Conversation
added 3 commits
May 2, 2017 15:09
- Display BR: compute isOverdue via GlideDateTime.after() and expose via g_scratchpad - Client onLoad: show g_form.addInfoMessage(...) on overdue, non-closed tasks - Hardened: addNotNullQuery(due_date), avoid server alert(), confirm state code - Scheduled job kept separate for background escalations via eventQueue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a visible banner on NeedIt Task forms when a record is overdue and not closed.
Server-side check done in a Display Business Rule; message rendered by a Client onLoad script.
What changed
isOverdueusingGlideDateTime.after(current.due_date)and exposes flags viag_scratchpad.g_scratchpad.isOverdueand displaysg_form.addInfoMessage(...).Files touched:
Why
Previously teams attempted to alert from a scheduled/background script (no UI context).
This split cleanly separates UI messaging (form load) from background processing.
How to test
x_58872_needit_needit_taskwith:due_datein the past, andstate≠ Closed Complete (verify your instance’s closed value; code currently assumes3).Implementation details
addNotNullQuerynot required here; Display runs on a single record).GlideDateTime.after(...)instead of string/locale compare.alert()(client-only).Backwards compatibility
Risks / mitigations
3in some environments, banner may show incorrectly.Mitigation: configurable state list in follow-up, or switch to an explicit “open states” allowlist.
Screenshots (optional)
Checklist